Update patch set 4

Browse Source

Patch Set 4: Code-Review+2

Looks great, just one problem with the copyrights. Unless the content was authored by an employee of the OpenStack Foundation or performed under contract from the foundation then the copyright statement is incorrect. You could change that to HP since you're an HP employee (since some of the authors were also HP employees), and then other authors could add copyright lines for their employers as well if they want.

However, since we're in a hurry to have this published on security.openstack.org prior to upcoming conference presentations/summit discussions I'm not going to block the review on that. It can be corrected in subsequent commits as time allows.

Also the copyright line on the VMT process document needs similar fixing, so let's make a point to get all that straightened out soon after the summit before we split them both out to the new security-site repo.

Patch-set: 4
Reviewer: Gerrit User 5263 <5263@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2

...

This commit is contained in:

Gerrit User 5263 2015-05-16 00:10:50 +00:00 committed by Gerrit Code Review

parent 7b80223d9b

commit 657aa315a5

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available