Update patch set 10

Patch Set 10: Code-Review-1

(2 comments)

Looks fine as a first step. See suggestion in rst.jinja to avoid duplicate headers. The other suggestion is for a subsequent change.

Patch-set: 10
Label: Code-Review=-1
This commit is contained in:
Gerrit User 308 2015-01-08 14:27:17 +00:00 committed by Gerrit Code Review
parent e3f3b12398
commit 9378dfca7a
1 changed files with 38 additions and 0 deletions

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "3a961159_81272cb5",
"filename": "doc/source/_exts/rst.jinja",
"patchSetId": 10
},
"lineNbr": 5,
"author": {
"id": 308
},
"writtenOn": "2015-01-08T14:27:17Z",
"side": 1,
"message": "I would put id and title on the same line, so that they don\u0027t appear as separate headers in the OSSA list.",
"revId": "dc0b65fce659566487eccf72100b55984f584dd1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a961159_61b6c026",
"filename": "doc/source/index.rst",
"patchSetId": 10
},
"lineNbr": 11,
"author": {
"id": 308
},
"writtenOn": "2015-01-08T14:27:17Z",
"side": 1,
"message": "This generates a chronological list, which is not very practical. It\u0027s probably fine as a first step, but it should be replaced at one point by a anti-chronological list of the 5-10 most recent advisories (with a link to see the complete chronological list). That will make room to place the content from http://www.openstack.org/projects/openstack-security/ on the main index page.",
"revId": "dc0b65fce659566487eccf72100b55984f584dd1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}