Update patch set 1
Patch Set 1: (8 comments) looks mostly good to me, i added a few comments inline. also, i might be off base with regard to the level of lightheartedness in this document. i don't mind the relaxed nature of the text but i think we should avoid humor that might be too colloquial. just my $0.02. Patch-set: 1 Label: Verified=0
This commit is contained in:
Gerrit User 10670
Gerrit Code Review
parent
bbd7994cc3
commit
a63667c721
|
|
@ -51,6 +51,41 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_8213280d",
|
||||
"filename": "doc/source/guidelines/dg_avoid-dangerous-input-parsing-libraries.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 40,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "+1",
|
||||
"parentUuid": "1aca2d91_4a2bec94",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_a0960aee",
|
||||
"filename": "doc/source/guidelines/dg_avoid-shell-true.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "this last line seems a little informal, is that acceptable?",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_20ea1110",
|
||||
|
|
@ -289,6 +324,40 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_5d271864",
|
||||
"filename": "doc/source/guidelines/dg_parameterize-database-queries.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 79,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "i feel like maybe there should be a little more about why this example could lead to an unsafe query. maybe bring some of the language from the correct example into this paragraph.",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_bdb50c32",
|
||||
"filename": "doc/source/guidelines/dg_parameterize-database-queries.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 167,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "i think this is funny, but not sure if it\u0027s appropriate. i know this is meant to be a more relaxed document and i don\u0027t have a strong objection to it, just wanted to raise the issue.",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_ef440a75",
|
||||
|
|
@ -340,6 +409,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_10a507a1",
|
||||
"filename": "doc/source/guidelines/dg_rootwrap-recommendations-and-plans.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "i think the second sentence could be rewritten a little clearer, maybe something like \"We have found that unused filters are left in place after they should have been removed.\"",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_1b00a400",
|
||||
|
|
@ -374,6 +460,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_d078aff4",
|
||||
"filename": "doc/source/guidelines/dg_rootwrap-recommendations-and-plans.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "i\u0027m not clear on the \"privileged daemon\" mentioned here, i assume this is a rootwrap daemon?",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_eae8787e",
|
||||
|
|
@ -391,6 +494,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_33136d0f",
|
||||
"filename": "doc/source/guidelines/dg_use-oslo-rootwrap-securely.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "*An example",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_7742fa11",
|
||||
|
|
@ -510,6 +630,24 @@
|
|||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1aca2d91_0e228852",
|
||||
"filename": "doc/source/guidelines/dg_validate-certificates.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 40,
|
||||
"author": {
|
||||
"id": 10670
|
||||
},
|
||||
"writtenOn": "2015-05-08T16:22:13Z",
|
||||
"side": 1,
|
||||
"message": "cheekyness aside, i think \"Customer\" might work better here.",
|
||||
"parentUuid": "1aca2d91_7110ca01",
|
||||
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue