openstack
/
ossa
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(31 comments)

Marked 'Done' the things fixed in the next patchset. I have addressed most things raised.

Patch-set: 1
This commit is contained in:
Gerrit User 7473 2015-05-15 05:57:10 +00:00 committed by Gerrit Code Review
parent 381d9e00f0
commit ce906d988a
1 changed files with 558 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

558
1430520eaebf7a587b582cb98b66812dd4c0b796
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_4c97c190",
"filename": "doc/source/guidelines/dg_avoid-dangerous-input-parsing-libraries.rst",
"patchSetId": 1
},
"lineNbr": 34,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_65fdbb39",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_a58ab3bd",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_2cdb657e",
"filename": "doc/source/guidelines/dg_avoid-dangerous-input-parsing-libraries.rst",
"patchSetId": 1
},
"lineNbr": 36,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Technically this is true. But I\u0027d rather discourage this type of code entirely where possible. Happy to include it in future revision.",
"parentUuid": "1aca2d91_a58ab3bd",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_4a2bec94",
@ -69,6 +105,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_0ce8a90f",
"filename": "doc/source/guidelines/dg_avoid-dangerous-input-parsing-libraries.rst",
"patchSetId": 1
},
"lineNbr": 40,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_8213280d",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_a0960aee",
@ -121,6 +175,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_cc829152",
"filename": "doc/source/guidelines/dg_avoid-unvalidated-redirects.rst",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_20ea1110",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_992164b7",
@ -138,6 +210,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_8c7c9973",
"filename": "doc/source/guidelines/dg_avoid-unvalidated-redirects.rst",
"patchSetId": 1
},
"lineNbr": 82,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_992164b7",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_9908442f",
@ -172,6 +262,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_a7f3ee72",
"filename": "doc/source/guidelines/dg_cross-site-request-forgery-csrf.rst",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_205fb1e6",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_ac3bc0d0",
@ -189,6 +297,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_c7eeea8a",
"filename": "doc/source/guidelines/dg_cross-site-request-forgery-csrf.rst",
"patchSetId": 1
},
"lineNbr": 13,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_ac3bc0d0",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_cab37ce8",
@ -206,6 +332,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_e7e2069f",
"filename": "doc/source/guidelines/dg_cross-site-request-forgery-csrf.rst",
"patchSetId": 1
},
"lineNbr": 19,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_cab37ce8",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_2c757097",
@ -223,6 +367,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_920f12e1",
"filename": "doc/source/guidelines/dg_cross-site-scripting-xss.rst",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_2c757097",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_40162df2",
@ -240,6 +402,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_b20a0ed1",
"filename": "doc/source/guidelines/dg_cross-site-scripting-xss.rst",
"patchSetId": 1
},
"lineNbr": 12,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_40162df2",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_eca53804",
@ -274,6 +454,42 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_32f73ed5",
"filename": "doc/source/guidelines/dg_cross-site-scripting-xss.rst",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_c0859d07",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_52fababe",
"filename": "doc/source/guidelines/dg_cross-site-scripting-xss.rst",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_eca53804",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_0ae174d0",
@ -291,6 +507,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_f20086ac",
"filename": "doc/source/guidelines/dg_cross-site-scripting-xss.rst",
"patchSetId": 1
},
"lineNbr": 40,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_0ae174d0",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_e0b65989",
@ -325,6 +559,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_32c85e55",
"filename": "doc/source/guidelines/dg_parameterize-database-queries.rst",
"patchSetId": 1
},
"lineNbr": 47,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_6a4a28c7",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_0a1614a7",
@ -342,6 +594,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_12c5623b",
"filename": "doc/source/guidelines/dg_parameterize-database-queries.rst",
"patchSetId": 1
},
"lineNbr": 72,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Ignoring this for now. Will revisit later.",
"parentUuid": "1aca2d91_0a1614a7",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_5d271864",
@ -359,6 +629,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_72b5b6cb",
"filename": "doc/source/guidelines/dg_parameterize-database-queries.rst",
"patchSetId": 1
},
"lineNbr": 79,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "I\u0027m going to leave this as is for now. Will revisit in a separate review.",
"parentUuid": "1aca2d91_5d271864",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_bdb50c32",
@ -376,6 +664,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_52cbda53",
"filename": "doc/source/guidelines/dg_parameterize-database-queries.rst",
"patchSetId": 1
},
"lineNbr": 167,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_bdb50c32",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_ef440a75",
@ -410,6 +716,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_12a0c29e",
"filename": "doc/source/guidelines/dg_protect-sensitive-data-in-files.rst",
"patchSetId": 1
},
"lineNbr": 38,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_af0df23f",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_8a0fc42d",
@ -427,6 +751,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_f29c066b",
"filename": "doc/source/guidelines/dg_protect-sensitive-data-in-files.rst",
"patchSetId": 1
},
"lineNbr": 58,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_8a0fc42d",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_10a507a1",
@ -444,6 +786,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_d28fca21",
"filename": "doc/source/guidelines/dg_rootwrap-recommendations-and-plans.rst",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_10a507a1",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_1b00a400",
@ -461,6 +821,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_b2944e37",
"filename": "doc/source/guidelines/dg_rootwrap-recommendations-and-plans.rst",
"patchSetId": 1
},
"lineNbr": 37,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_1b00a400",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_ec41b80c",
@ -478,6 +856,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_729ed657",
"filename": "doc/source/guidelines/dg_rootwrap-recommendations-and-plans.rst",
"patchSetId": 1
},
"lineNbr": 39,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_ec41b80c",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_d078aff4",
@ -495,6 +891,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_32a17e95",
"filename": "doc/source/guidelines/dg_rootwrap-recommendations-and-plans.rst",
"patchSetId": 1
},
"lineNbr": 68,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Not sure either. Leaving for now.",
"parentUuid": "1aca2d91_d078aff4",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_eae8787e",
@ -512,6 +926,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_b2e20ed4",
"filename": "doc/source/guidelines/dg_strong-crypto.rst",
"patchSetId": 1
},
"lineNbr": 38,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "I believe this is still a valid concern. I will address this at the summit.",
"parentUuid": "1aca2d91_eae8787e",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_33136d0f",
@ -529,6 +961,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_12dc4211",
"filename": "doc/source/guidelines/dg_use-oslo-rootwrap-securely.rst",
"patchSetId": 1
},
"lineNbr": 26,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_33136d0f",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_7742fa11",
@ -546,6 +996,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_b209ee97",
"filename": "doc/source/guidelines/dg_use-subprocess-securely.rst",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_7742fa11",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_575c9eec",
@ -563,6 +1031,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_32f61e90",
"filename": "doc/source/guidelines/dg_using-file-paths.rst",
"patchSetId": 1
},
"lineNbr": 1,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_575c9eec",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_4a476c4b",
@ -580,6 +1066,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_323dfe2b",
"filename": "doc/source/guidelines/dg_validate-certificates.rst",
"patchSetId": 1
},
"lineNbr": 4,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_4a476c4b",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_ea6d1805",
@ -597,6 +1101,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_32d97ef4",
"filename": "doc/source/guidelines/dg_validate-certificates.rst",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_ea6d1805",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_aa97208f",
@ -614,6 +1136,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_92d152d0",
"filename": "doc/source/guidelines/dg_validate-certificates.rst",
"patchSetId": 1
},
"lineNbr": 20,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_aa97208f",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1aca2d91_e8e3d631",
@ -666,6 +1206,24 @@
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a016987_52dcfae3",
"filename": "doc/source/guidelines/dg_validate-certificates.rst",
"patchSetId": 1
},
"lineNbr": 40,
"author": {
"id": 7473
},
"writtenOn": "2015-05-15T05:57:10Z",
"side": 1,
"message": "Done",
"parentUuid": "1aca2d91_e8e3d631",
"revId": "1430520eaebf7a587b582cb98b66812dd4c0b796",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}