ossa/f84e12955e5620d3ba718c7d536eca6c7bf77f5e

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "ff75bc52_b121eaef",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 1
      },
      "lineNbr": 0,
      "author": {
        "id": 5314
      },
      "writtenOn": "2023-05-10T16:50:35Z",
      "side": 1,
      "message": "A few comments inline.",
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "81425e41_4a45ed03",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 42,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "Reading this now, I think it should be:\n\n\"Cinder must only accept attachment delete requests from Nova for instance-attached volumes\"",
      "range": {
        "startLine": 42,
        "startChar": 9,
        "endLine": 42,
        "endChar": 62
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "fce82d5f_8ac7f1c9",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 42,
      "author": {
        "id": 5314
      },
      "writtenOn": "2023-05-10T16:50:35Z",
      "side": 1,
      "message": "Agree, Dan\u0027s suggestion reads better.",
      "parentUuid": "81425e41_4a45ed03",
      "range": {
        "startLine": 42,
        "startChar": 9,
        "endLine": 42,
        "endChar": 62
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d948ba4e_924fd6ef",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 59,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "Probably a colon here",
      "range": {
        "startLine": 59,
        "startChar": 10,
        "endLine": 59,
        "endChar": 13
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "09918869_d7dc538f",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 62,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "Probably better to rearrange these as it\u0027s confusing:\n\n\"for fibre channel, which has only been available for iSCSI until now (covered...\"",
      "range": {
        "startLine": 61,
        "startChar": 63,
        "endLine": 62,
        "endChar": 57
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "9307025c_9f659dc1",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 66,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "This should be \"deleted instances\" as that\u0027s the only thing we\u0027re changing. We don\u0027t use force for regular detach because that could result in data loss.",
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "30f62762_29a54e97",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 69,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "This should have been \"backend\" .. we had this realization downstream an hour ago. The glance_store is a reference to a project, but the users see it as a backend in glance.",
      "range": {
        "startLine": 69,
        "startChar": 49,
        "endLine": 69,
        "endChar": 61
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "96048650_b8de0a81",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 69,
      "author": {
        "id": 5314
      },
      "writtenOn": "2023-05-10T16:50:35Z",
      "side": 1,
      "message": "I don\u0027t know about this one.  It\u0027s the cinder glance_store driver that we\u0027re talking about.",
      "parentUuid": "30f62762_29a54e97",
      "range": {
        "startLine": 69,
        "startChar": 49,
        "endLine": 69,
        "endChar": 61
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6bf370ae_5900372a",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 69,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:55:01Z",
      "side": 1,
      "message": "Okay, this case from a conversation between gorka and rajat in another forum. Not critical and worth holding things up.",
      "parentUuid": "96048650_b8de0a81",
      "range": {
        "startLine": 69,
        "startChar": 49,
        "endLine": 69,
        "endChar": 61
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "c8089ae0_e68fbc38",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 97,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "Should this be a link? This is in the not-yet-merged bit though.",
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "ca727cdf_27549dde",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 99,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "\"backend for glance\"",
      "range": {
        "startLine": 99,
        "startChar": 16,
        "endLine": 99,
        "endChar": 28
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "90751875_bebd1575",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 99,
      "author": {
        "id": 5314
      },
      "writtenOn": "2023-05-10T16:50:35Z",
      "side": 1,
      "message": "No, make it \"cinder glance_store driver\" if it\u0027s not clear.",
      "parentUuid": "ca727cdf_27549dde",
      "range": {
        "startLine": 99,
        "startChar": 16,
        "endLine": 99,
        "endChar": 28
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "3021cb89_8b949536",
        "filename": "ossa/OSSA-2023-003.yaml",
        "patchSetId": 1
      },
      "lineNbr": 108,
      "author": {
        "id": 4393
      },
      "writtenOn": "2023-05-10T16:38:53Z",
      "side": 1,
      "message": "\"periodic tasks and some nova-manage actions\" (no cleanup)\n\nSome of the periodics are for cleanup, but not all.",
      "range": {
        "startLine": 108,
        "startChar": 2,
        "endLine": 108,
        "endChar": 15
      },
      "revId": "f84e12955e5620d3ba718c7d536eca6c7bf77f5e",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}