openstack/ovn-octavia-provider
Code Issues Proposed changes

Remove join on helper request daemon thread

Browse Source 
This patch remove the join over the request daemon thread
attending the request on the OVN-provider. This is generating a
deadlock when the GC is called over the driver class calling the
helper shutdown, and the request thread is attending any previous
request (through ovsdbapp using a lock over the txn on OVN DBs)

As the request thread is a daemon thread this operation looks safe.

Closes-Bug: #2093347

Change-Id: I464f6cebf3c65f300a3d0f10b661f77215475a7e
This commit is contained in:
Fernando Royo
2025-01-09 10:50:09 +01:00
parent e87aeed5d5
commit 26431c9ab1
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ovn_octavia_provider/helper.py
View File

@@ -109,7 +109,6 @@ class OvnProviderHelper():
def shutdown(self): def shutdown(self):
self.requests.put({'type': ovn_const.REQ_TYPE_EXIT}, self.requests.put({'type': ovn_const.REQ_TYPE_EXIT},
timeout=ovn_const.MAX_TIMEOUT_REQUEST) timeout=ovn_const.MAX_TIMEOUT_REQUEST)
self.helper_thread.join()
@staticmethod @staticmethod
def _map_val(row, col, key): def _map_val(row, col, key):