openstack/ovn-octavia-provider
Code Issues Proposed changes

Increase code coverage

Browse Source 
Coverage tests is flickering over the threshold configured on 92%.
(without knowing the reason)

This patch adds additional unit tests to  files that has been
flickering in the last running cover jobs, in order to keep the
results in a more stable line.

Change-Id: I1cadb861ff5eb8cf6379d561e693a967fd5b90fc
This commit is contained in:
Fernando Royo
2022-11-21 15:41:00 +01:00
parent a2b3561ee6
commit 71055bf302
2 changed files with 52 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
ovn_octavia_provider/tests/unit/hacking/test_checks.py
View File

@@ -100,6 +100,9 @@ class HackingTestCase(base.BaseTestCase):
self.assertEqual(
0, len(list(checks.check_assert_called_once_with(pass_code2,
"ovn_octavia_provider/tests/test_assert.py"))))
self.assertEqual(
0, len(list(checks.check_assert_called_once_with(pass_code2,
"ovn_octavia_provider/tests_fake/test_assert.py"))))
def test_asserttruefalse(self):
true_fail_code1 = """
@@ -144,6 +147,10 @@ class HackingTestCase(base.BaseTestCase):
self.assertFalse(
list(checks.check_asserttruefalse(false_pass_code,
"ovn_octavia_provider/tests/test_assert.py")))
self.assertEqual(
0, len(list(checks.check_asserttruefalse(
true_pass_code,
"ovn_octavia_provider/tests_fake/test_assert.py"))))
def test_assertempty(self):
fail_code = """
@@ -168,6 +175,11 @@ class HackingTestCase(base.BaseTestCase):
self.assertEqual(
0, len(list(checks.check_asserttruefalse(pass_code2 % ec,
"ovn_octavia_provider/tests/test_assert.py"))))
self.assertEqual(
0, len(list(
checks.check_asserttruefalse(
pass_code2 % ec,
"ovn_octavia_provider/tests_fake/test_assert.py"))))
def test_assertisinstance(self):
fail_code = """
@@ -188,6 +200,9 @@ class HackingTestCase(base.BaseTestCase):
self.assertEqual(
0, len(list(checks.check_assertisinstance(pass_code2,
"ovn_octavia_provider/tests/test_assert.py"))))
self.assertEqual(
0, len(list(checks.check_assertisinstance(pass_code2,
"ovn_octavia_provider/tests_fake/test_assert.py"))))
def test_assertequal_for_httpcode(self):
fail_code = """
@@ -202,6 +217,9 @@ class HackingTestCase(base.BaseTestCase):
self.assertEqual(
0, len(list(checks.check_assertequal_for_httpcode(pass_code,
"ovn_octavia_provider/tests/test_assert.py"))))
self.assertEqual(
0, len(list(checks.check_assertequal_for_httpcode(pass_code,
"ovn_octavia_provider/tests_fake/test_assert.py"))))
def test_check_no_imports_from_tests(self):
fail_codes = ('from ovn_octavia_provider import tests',
@@ -246,3 +264,9 @@ class HackingTestCase(base.BaseTestCase):
fail_line,
"ovn_octavia_provider/tests/test_fake.py",
None))))
self.assertEqual(
0, len(list(
checks.check_no_import_mock(
fail_line,
"ovn_octavia_provider/tests/test_fake.py",
True))))

28
ovn_octavia_provider/tests/unit/test_driver.py
View File

@@ -242,6 +242,13 @@ class TestOvnProviderDriver(ovn_base.TestOvnOctaviaBase):
self.ref_member.address = 'fc00::1'
self.assertTrue(self.driver._ip_version_differs(self.ref_member))
def test__ip_version_differs_lb_not_found(self):
self.mock_find_ovn_lb_by_pool_id = mock.patch.object(
ovn_helper.OvnProviderHelper,
'_find_ovn_lb_by_pool_id').start()
self.mock_find_ovn_lb_by_pool_id.return_value = (_, None)
self.assertFalse(self.driver._ip_version_differs(self.ref_member))
def test__ip_version_differs_pool_disabled(self):
self.mock_find_lb_pool_key.side_effect = [None, self.ovn_lb]
self.driver._ip_version_differs(self.ref_member)
@@ -323,6 +330,10 @@ class TestOvnProviderDriver(ovn_base.TestOvnOctaviaBase):
member.subnet_id = None
self._test_member_create(member)
def test__check_monitor_options_member_no_monitor_data(self):
self.ref_member.monitor_address = None
self.assertFalse(self.driver._check_monitor_options(self.ref_member))
def test_member_create_monitor_opts(self):
self.ref_member.monitor_address = '172.20.20.1'
self.assertRaises(exceptions.UnsupportedOptionError,
@@ -396,6 +407,15 @@ class TestOvnProviderDriver(ovn_base.TestOvnOctaviaBase):
self.driver.member_update(member, self.update_member)
self.mock_add_request.assert_called_once_with(expected_dict)
def test_member_update_missing_subnet_id_differs_from_lb_vip(self):
self.driver._ovn_helper._get_subnet_from_pool.return_value = (
self.ref_member.subnet_id, '198.52.100.0/24')
self.driver._ovn_helper._check_ip_in_subnet.return_value = False
self.ref_member.subnet_id = data_models.UnsetType()
self.assertRaises(exceptions.UnsupportedOptionError,
self.driver.member_update, self.ref_member,
self.update_member)
@mock.patch.object(ovn_driver.OvnProviderDriver, '_ip_version_differs')
def test_member_update_no_ip_addr(self, mock_ip_differs):
self.update_member.address = None
@@ -518,6 +538,14 @@ class TestOvnProviderDriver(ovn_base.TestOvnOctaviaBase):
mock.call(expected_dict_dvr)]
self.mock_add_request.assert_has_calls(expected)
def test_member_delete_missing_subnet_id_differs_from_lb_vip(self):
self.driver._ovn_helper._get_subnet_from_pool.return_value = (
self.ref_member.subnet_id, '198.52.100.0/24')
self.driver._ovn_helper._check_ip_in_subnet.return_value = False
self.ref_member.subnet_id = data_models.UnsetType()
self.assertRaises(exceptions.UnsupportedOptionError,
self.driver.member_delete, self.ref_member)
def test_listener_create(self):
info = {'id': self.ref_listener.listener_id,
'protocol': self.ref_listener.protocol,