openstack
/
paunch
Code Issues Proposed changes

Do not always needlessly pull the images via podman 

Via https://review.opendev.org/#/c/665731/ there was a tentative
reduction of podman inspect calls. The problem was that a podman
pull was performed even when the image already existed due to
a wrong if check, since image_exist() returns true/false and not
the return code of the podman image shell command.

Closes-Bug: #1855128
Co-Authored-By: Damien Ciabrini <dciabrin@redhat.com>

Change-Id: Ia0c71de6a0a1fe243a39dbd7b1458610b81bd6be
This commit is contained in:
Michele Baldessari 2019-12-04 15:52:25 +01:00
parent 43876b01b9
commit 14fa098fcb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
paunch/builder/base.py
View File

@ -295,7 +295,7 @@ class BaseBuilder(object):
continue
else:
img_exist = self.runner.image_exist(image)
if img_exist == 0:
if img_exist:
continue
try: