openstack
/
paunch
Code Issues Proposed changes

Optimize container CLI for getting unique names 

Do not call it twice in the while{} loop. It is pointless to
double-check for a container existence after we have determined weither
its name is in use or not.

This decreases the pressure on the container system.

Change-Id: Ife65f082f389ad4a730b3f9cf07d32ac4be32b45
Signed-off-by: Bogdan Dobrelya <bdobreli@redhat.com>
This commit is contained in:
Bogdan Dobrelya 2019-07-30 15:19:42 +02:00
parent 6ca0170eeb
commit a6df749249
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
paunch/runner.py
View File

@ -123,11 +123,13 @@ class BaseRunner(object):
suffix = ''.join(random.choice(
string.ascii_lowercase + string.digits) for i in range(8))
container_name = '%s-%s' % (container, suffix)
break
else:
while self.container_exist(container_name, quiet=True):
suffix = ''.join(random.choice(
string.ascii_lowercase + string.digits) for i in range(8))
container_name = '%s-%s' % (container, suffix)
break
return container_name
def discover_container_name(self, container, cid):