Merge "Add a hacking rule for string interpolation at logging"

HACKING.rst

@@ -64,6 +64,7 @@ Nova Specific Commandments
 - [N351] Do not use the oslo_policy.policy.Enforcer.enforce() method.
 - [N352] LOG.warn is deprecated. Enforce use of LOG.warning.
 - [N353] Validate that context objects is not passed in logging calls.
+- [N354] String interpolation should be delayed at logging calls.
 
 Creating Unit Tests
 -------------------

nova/scheduler/filters/aggregate_image_properties_isolation.py

@@ -51,8 +51,8 @@ class AggregateImagePropertiesIsolation(filters.BaseHostFilter):
                 prop = image_props.get(key)
             except AttributeError:
                 LOG.warning(_LW("Host '%(host)s' has a metadata key '%(key)s' "
-                                "that is not present in the image metadata.") %
-                                {"host": host_state.host, "key": key})
+                                "that is not present in the image metadata."),
+                            {"host": host_state.host, "key": key})
                 continue
 
             # NOTE(sbauza): Aggregate metadata is only strings, we need to