openstack/placement
Code Issues Proposed changes

Merge "Use more specific asserts in tests"

Browse Source
This commit is contained in:
Jenkins 2016-10-12 17:52:57 +00:00 committed by Gerrit Code Review
commit 165556a03d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nova/test.py
View File

@ -392,7 +392,7 @@ class APICoverage(object):
cover_api = None cover_api = None
def test_api_methods(self): def test_api_methods(self):
self.assertTrue(self.cover_api is not None) self.assertIsNotNone(self.cover_api)
api_methods = [x for x in dir(self.cover_api) api_methods = [x for x in dir(self.cover_api)
if not x.startswith('_')] if not x.startswith('_')]
test_methods = [x[5:] for x in dir(self) test_methods = [x[5:] for x in dir(self)

4
nova/tests/functional/db/test_aggregate.py
View File

@ -132,8 +132,8 @@ class AggregateObjectDbTestCase(test.NoDBTestCase):
cell_db_agg = aggregate_obj.Aggregate.get_by_id( cell_db_agg = aggregate_obj.Aggregate.get_by_id(
self.context, ca2['id']) self.context, ca2['id'])
self.assertEqual(api_db_agg.in_api, True) self.assertTrue(api_db_agg.in_api)
self.assertEqual(cell_db_agg.in_api, False) self.assertFalse(cell_db_agg.in_api)
def test_aggregate_get_from_db(self): def test_aggregate_get_from_db(self):
result = _create_aggregate_with_hosts(self.context) result = _create_aggregate_with_hosts(self.context)