openstack
/
placement
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+2

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 4690 <4690@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, a6fe2b0d063683d69c01a0d6ddfda07ebc70bcca
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_4690\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 4690 \u003c4690@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_4690\u003e replied on the change"}
This commit is contained in:
Gerrit User 4690 2023-06-14 23:38:35 +00:00 committed by Gerrit Code Review
parent d977002985
commit 18e1d82c16
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
d00a9fedd532ecde6516d9c35f0d359d40779b2d
View File

@ -17,6 +17,23 @@
"revId": "d00a9fedd532ecde6516d9c35f0d359d40779b2d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "70bee9b5_0b2ff1a5",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 4690
},
"writtenOn": "2023-06-14T23:38:35Z",
"side": 1,
"message": "Looks OK to me",
"revId": "d00a9fedd532ecde6516d9c35f0d359d40779b2d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +86,24 @@
"parentUuid": "01a518f0_051fd01f",
"revId": "d00a9fedd532ecde6516d9c35f0d359d40779b2d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d1c0233c_b2642202",
"filename": "placement/tests/functional/base.py",
"patchSetId": 1
},
"lineNbr": 49,
"author": {
"id": 4690
},
"writtenOn": "2023-06-14T23:38:35Z",
"side": 1,
"message": "That is what I thought but I wasn\u0027t sure, thanks. I think it\u0027s OK, I just wanted to make sure I understand before +2\u0027ing. We could enhance things to emit a more explicit error if later on it proves to be too opaque.",
"parentUuid": "81de39bb_5b02d265",
"revId": "d00a9fedd532ecde6516d9c35f0d359d40779b2d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}