openstack/placement
Code Issues Proposed changes

Test case for multiple forbidden traits

Browse Source 
Test case to expose a bug at [1] where symmetric difference (^) is being
used instead of difference (-).

[1] https://review.openstack.org/#/c/590041/6/nova/api/openstack/placement/objects/resource_provider.py@2911

Change-Id: I2e80fe75da1d1104d0562f087c74117fbe6b457b
This commit is contained in:
Eric Fried 2018-08-10 14:41:01 -05:00 committed by Jay Pipes
parent 4faaf492af
commit 27fd442fd3
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py
View File

@ -208,6 +208,26 @@ class ProviderDBHelperTestCase(tb.PlacementDbBaseTestCase):
rp_ids = [r[0] for r in res]
self.assertEqual([incl_biginv_noalloc.id], rp_ids)
def test_get_provider_ids_matching_with_multiple_forbidden(self):
rp1 = self._create_provider('rp1', uuids.agg1)
tb.add_inventory(rp1, fields.ResourceClass.VCPU, 64)
rp2 = self._create_provider('rp2', uuids.agg1)
trait_two, = tb.set_traits(rp2, 'CUSTOM_TWO')
tb.add_inventory(rp2, fields.ResourceClass.VCPU, 64)
rp3 = self._create_provider('rp3')
trait_three, = tb.set_traits(rp3, 'CUSTOM_THREE')
tb.add_inventory(rp3, fields.ResourceClass.VCPU, 64)
resources = {
fields.ResourceClass.STANDARD.index(fields.ResourceClass.VCPU): 4}
res = rp_obj._get_provider_ids_matching(
self.ctx, resources, {},
{trait_two.name: trait_two.id,
trait_three.name: trait_three.id}, member_of=[[uuids.agg1]])
self.assertEqual({(rp1.id, rp1.id)}, set(res))
def test_get_provider_ids_having_all_traits(self):
def run(traitnames, expected_ids):
tmap = {}