openstack/placement
Code Issues Proposed changes

Update HACKING.rst per recent changes

Browse Source 
Added "is not" usage with examples
* https://review.openstack.org/#/c/20865/

Fixed "not in" usage description
* https://review.openstack.org/#/c/20875/

Fixed some "not X in Y" corner cases.

Change-Id: I7534ef73e6fd525fd8f4bee594a4b37524699c08
This commit is contained in:
Zhongyue Luo 2013-02-04 10:07:08 +08:00
parent 317004fdc7
commit 2baf604ac3
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
HACKING.rst
View File

@ -28,16 +28,23 @@ General
mylist = Foo().list() # OKAY, does not shadow built-in
- Use the "is not" operator when testing for unequal identities. Example::
- Use the "not in" operator for collection membership evaluation. Example::
if not X is Y: # BAD, intended behavior is ambiguous
pass
if not X in Y: # BAD, hard to understand
if X is not Y: # OKAY, intuitive
pass
- Use the "not in" operator for evaluating membership in a collection. Example::
if not X in Y: # BAD, intended behavior is ambiguous
pass
if X not in Y: # OKAY, intuitive
pass
if not (X in Y or X is Z): # OKAY, still better than all those 'not's
if not (X in Y or X in Z): # OKAY, still better than all those 'not's
pass