6453bd2f5a
The direct access of conf.* names in _get_db_conf() method is an inappropriate usage of oslo.config [1]. Hardcoding these names prevents oslo.db from being able to easily rename or deprecate options, as well as to be able to add new database options, such as those which apply to new performance tuning or monitoring techniques. Retrieve values from the config object generically so that these names remain local to oslo.db. This usage has been supported in oslo.db enginefacade from its inception [2] as multiple projects were already doing it for LegacyEngineFacade. For the keys __autocommit, sqlite_fk, and expire_on_commit, enginefacade already defaults these to the same values as were hardcoded here and these are unnecessary to be hardcoded. __autocommit in particular is not public. [1] http://lists.openstack.org/pipermail/openstack-dev/2017-July/119846.html [2] https://github.com/openstack/oslo.db/blob/master/oslo_db/tests/sqlalchemy/test_enginefacade.py#L2140 Change-Id: I22f8a19009408fb1f1587bf399e6aee3467c8bc6 |
||
|---|---|---|
| .. | ||
| sqlalchemy | ||
| __init__.py | ||
| api.py | ||
| base.py | ||
| migration.py | ||