bafc0f8d9c
If an attached encrypted volume is failed to detach from the instance when deleting that instance, user can not delete that instance at all. This patch adds 4 in check_exit_code when executing `cryptsetup remove` command to eat that exception. PS: exit_code = 4 indicate ENODEV error which means no device(also includes the crypt device inactive). Closes-Bug: #1482066 Change-Id: I12e2a52068850528a4bd68486344b74eb9b82c88
105 lines
3.8 KiB
Python
105 lines
3.8 KiB
Python
# Copyright (c) 2013 The Johns Hopkins University/Applied Physics Laboratory
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
|
|
import array
|
|
|
|
import mock
|
|
import six
|
|
|
|
from nova import exception
|
|
from nova.keymgr import key
|
|
from nova.tests.unit.volume.encryptors import test_base
|
|
from nova.volume.encryptors import cryptsetup
|
|
|
|
|
|
def fake__get_key(context):
|
|
raw = array.array('B', ('0' * 64).decode('hex')).tolist()
|
|
|
|
symmetric_key = key.SymmetricKey('AES', raw)
|
|
return symmetric_key
|
|
|
|
|
|
class CryptsetupEncryptorTestCase(test_base.VolumeEncryptorTestCase):
|
|
def _create(self, connection_info):
|
|
return cryptsetup.CryptsetupEncryptor(connection_info)
|
|
|
|
def setUp(self):
|
|
super(CryptsetupEncryptorTestCase, self).setUp()
|
|
|
|
self.dev_path = self.connection_info['data']['device_path']
|
|
self.dev_name = self.dev_path.split('/')[-1]
|
|
|
|
self.symlink_path = self.dev_path
|
|
|
|
@mock.patch('nova.utils.execute')
|
|
def test__open_volume(self, mock_execute):
|
|
self.encryptor._open_volume("passphrase")
|
|
|
|
mock_execute.assert_has_calls([
|
|
mock.call('cryptsetup', 'create', '--key-file=-', self.dev_name,
|
|
self.dev_path, process_input='passphrase',
|
|
run_as_root=True, check_exit_code=True),
|
|
])
|
|
self.assertEqual(1, mock_execute.call_count)
|
|
|
|
@mock.patch('nova.utils.execute')
|
|
def test_attach_volume(self, mock_execute):
|
|
self.encryptor._get_key = mock.MagicMock()
|
|
self.encryptor._get_key.return_value = fake__get_key(None)
|
|
|
|
self.encryptor.attach_volume(None)
|
|
|
|
mock_execute.assert_has_calls([
|
|
mock.call('cryptsetup', 'create', '--key-file=-', self.dev_name,
|
|
self.dev_path, process_input='0' * 32,
|
|
run_as_root=True, check_exit_code=True),
|
|
mock.call('ln', '--symbolic', '--force',
|
|
'/dev/mapper/%s' % self.dev_name, self.symlink_path,
|
|
run_as_root=True, check_exit_code=True),
|
|
])
|
|
self.assertEqual(2, mock_execute.call_count)
|
|
|
|
@mock.patch('nova.utils.execute')
|
|
def test__close_volume(self, mock_execute):
|
|
self.encryptor.detach_volume()
|
|
|
|
mock_execute.assert_has_calls([
|
|
mock.call('cryptsetup', 'remove', self.dev_name,
|
|
run_as_root=True, check_exit_code=[0, 4]),
|
|
])
|
|
self.assertEqual(1, mock_execute.call_count)
|
|
|
|
@mock.patch('nova.utils.execute')
|
|
def test_detach_volume(self, mock_execute):
|
|
self.encryptor.detach_volume()
|
|
|
|
mock_execute.assert_has_calls([
|
|
mock.call('cryptsetup', 'remove', self.dev_name,
|
|
run_as_root=True, check_exit_code=[0, 4]),
|
|
])
|
|
self.assertEqual(1, mock_execute.call_count)
|
|
|
|
def test_init_volume_encryption_not_supported(self):
|
|
# Tests that creating a CryptsetupEncryptor fails if there is no
|
|
# device_path key.
|
|
type = 'unencryptable'
|
|
data = dict(volume_id='a194699b-aa07-4433-a945-a5d23802043e')
|
|
connection_info = dict(driver_volume_type=type, data=data)
|
|
exc = self.assertRaises(exception.VolumeEncryptionNotSupported,
|
|
cryptsetup.CryptsetupEncryptor,
|
|
connection_info)
|
|
self.assertIn(type, six.text_type(exc))
|