6589a7866d
This change removes the NovaObjectDictCompat mixin from the Aggregate versioned object. All occurrences of key access or get have been changed to use getattr/setattr. Because none of the objects externally-facing functionality has changed, the object version does not need to be updated. There was a fake aggregate in the xen api tests that contained two empty dictionaries for a couple of keys in the metadata. These are actually strings in the code, so they have been changed to empty strings. Within the tests for the aggregate API, the fake dictionaries that were returned by the AggregateAPI stubs were structured incorrectly. Within the object, the availability zone is stored in the metadata dictionary, not the top-level dictionary. Also, those dictionaries were changed to Aggregate objects, so the stubs now return true objects (similar to how the actual code works). The result of the calls are then compared by the object primitives. There was usage of .items() in _marshall_aggregate() within the api controller for aggregates, so a unit test was added to run through that function to make sure it is transforming the aggregate object correctly. (props to Tempest for finding that one for me). Partially-Implements: bp rm-object-dict-compat Change-Id: Ibcb896b2eef673bce23491161ff394bcc87aa541 |
||
|---|---|---|
| .. | ||
| api/openstack/compute | ||
| objects | ||
| scheduler/filters | ||
| volume/encryptors | ||
| __init__.py | ||
| policy_fixture.py | ||
| README.rst | ||
OpenStack Nova Testing Infrastructure
This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.
Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure
Test Types: Unit vs. Functional vs. Integration
TBD
Writing Unit Tests
TBD
Using Fakes
TBD
test.TestCase
The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.
If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.
Writing Functional Tests
TBD
Writing Integration Tests
TBD
Tests and Exceptions
A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.
In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.
This applies to catching exceptions manually with a try/except block, or using assertRaises().
Example:
self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
elevated, instance_uuid)If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.
Example:
def stubbed_method(self):
raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)
obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)Stubbing and Mocking
Whenever possible, tests SHOULD NOT stub and mock out the same function.
If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.
If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.