bed7808b59
Turn ResourceProvider and ResourceProviderList into classical Python objects. There are two changes here which deserve particular attention because they are more changing than the other OVO removals: * There were two deepcopy calls in the allocation request handling. When using OVO, the __deepcopy__ handling built into it prevents deep recursion. I changed them to copy and things still work as expected. This will be because using the nested objects by reference is acceptable. * The removal of OVO removes the detection of changed fields. This was being used when creating and saving resource providers (at the object level) to automagically detect and prevent writing fields we don't want to. This change removes that functionality. Instead if bad data has made it as far as the create or save calls, we simply don't write it. The HTTP layer continues to maintain the guards it already had in place to prevent badness. Tests which were testing the object layer are removed. The create_provider function in functional/db/test_base allowed (trying to) create a provider with a root but that functionality was only called from one place. That place and the functionality in create_provider is removed. Other things to note: * As with the other changes, where context is actually used by the object it is required in the constructor. This cascades some changes to tests. * A test that checks to see if adding traits resets the changes on a rp has been removed, because we don't track that any more if we haven't got OVO. * The last_modified handling in placement/util no longer need NotImplemented handling, that was an artifact of OVO. oslo.versionedobjects is removed from requirements. This doesn't have a huge impact on the size of the virtualenv: 114M -> 107M [1] but it does take us from 132 python dependencies (via pip list) to 119, removing plenty of stuff that was only being called in because stuff that we don't use depended on it. lower-constraints.txt is updated to reflect the removal of dependencies that are no longer needed. [1] Of note, 26M of that is babel. Do we need to translate exceptions? See email disussion at http://lists.openstack.org/pipermail/openstack-discuss/2019-February/thread.html#3002 Change-Id: Ie0a9351e0d7c762c9c96c45cbe50132a0fbd1486 |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| test_aggregate.py | ||
| test_util.py | ||