openstack/project-config
Code Issues Proposed changes

Remove explicit bindep parameters

Browse Source 
All of these invocations of the bindep role are passing what amount to
the defaults. In zuul-jobs, doing bindep_dir: "{{ zuul_work_dir }}" is
important because it allows in-repo uses of those jobs to override how
they work for things like triggering from one repo but running on
another.

The publication jobs in project-config do not need that level of
flexibility, so just remove params and let defaults take over.

As a follow up, we could also add defaults for zuul_work_dir - and
honestly for bindep_dir - to the base job. That way we can always count
on them being set to a sane default value, and they're still
overrideable in a job.

Change-Id: I5bcda84aefa4726d0a904e8bc9698c21ca07f9a5
This commit is contained in:
Monty Taylor 2018-01-05 10:26:46 -06:00 committed by Andreas Jaeger
parent 0a93ac9d16
commit 09da196701
9 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
playbooks/javascript/pre.yaml
View File

@ -1,8 +1,6 @@
- hosts: all
roles:
- role: bindep
bindep_profile: test
bindep_dir: "{{ zuul_work_dir }}"
- bindep
- test-setup
- install-nodejs
- revoke-sudo

4
playbooks/project-config/pre-tox.yaml
View File

@ -1,7 +1,5 @@
- hosts: all
roles:
- role: bindep
bindep_profile: test
bindep_dir: "{{ zuul_work_dir|default(omit) }}"
- bindep
- ensure-tox
- revoke-sudo

4
playbooks/proposal/pre.yaml
View File

@ -11,7 +11,5 @@
gitreview.username: proposal-bot
- legacy-copy-project-config-scripts
- add-sshkey
- role: bindep
bindep_profile: test
bindep_dir: "{{ zuul.project.src_dir }}"
- bindep
- ensure-tox

4
playbooks/python-tarball/pre.yaml
View File

@ -1,7 +1,5 @@
- hosts: all
roles:
- role: bindep
bindep_profile: test
bindep_dir: "src/{{ zuul.project.canonical_name }}"
- bindep
- ensure-tox
- revoke-sudo

4
playbooks/release/pre.yaml
View File

@ -16,9 +16,7 @@
user.email: infra-root@openstack.org
user.signingkey: infra-root@openstack.org
gitreview.username: release
- role: bindep
bindep_profile: test
bindep_dir: "src/{{ zuul.project.canonical_name }}"
- bindep
- legacy-copy-project-config-scripts
- add-sshkey
- add-launchpad-credentials

1
playbooks/releasenotes/pre.yaml
View File

@ -2,7 +2,6 @@
roles:
- role: bindep
bindep_profile: doc
bindep_dir: "{{ zuul_work_dir }}"
- role: ensure-sphinx
doc_building_packages:
- sphinx

1
playbooks/sphinx/pre.yaml
View File

@ -2,6 +2,5 @@
roles:
- role: bindep
bindep_profile: doc
bindep_dir: "{{ zuul_work_dir|default(omit) }}"
- ensure-sphinx
- revoke-sudo

4
playbooks/wheel/pre.yaml
View File

@ -1,8 +1,6 @@
- hosts: all
roles:
- role: bindep
bindep_profile: test
bindep_dir: "src/{{ zuul.project.canonical_name }}"
- bindep
- legacy-install-afs-with-puppet
- legacy-copy-project-config-scripts

4
playbooks/yaml2ical/pre.yaml
View File

@ -1,7 +1,5 @@
- hosts: all
roles:
- role: bindep
bindep_profile: test
bindep_dir: "src/{{ zuul.project.canonical_name }}"
- bindep
- ensure-tox
- revoke-sudo