openstack/project-config
Code Issues Proposed changes

Correct command line logic in pypi-extract-name.py

Browse Source 
Since sys.argv is always of nonzero length, the logic in
command-line parsing should expect it to either be 1 element long
(no arguments) or test the first argument (sys.argv[1]).

Change-Id: Ic7cf65ac89754d6aaa53fa361860f04533cb48be
This commit is contained in:
Jeremy Stanley 2016-08-05 17:28:14 +00:00
parent 287b52f7f2
commit 1118cbe76a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jenkins/scripts/pypi-extract-name.py
View File

@ -23,7 +23,7 @@ setup_cfg = ConfigParser.SafeConfigParser()
setup_cfg.read("setup.cfg")
distname = setup_cfg.get("metadata", "name")
assert distname
if not len(sys.argv) or sys.argv[1] == "--tarball":
if len(sys.argv) == 1 or sys.argv[1] == "--tarball":
print(distname)
elif sys.argv[1] == "--wheel":
print(wheel.bdist_wheel.safer_name(distname))