openstack/project-config
Code Issues Proposed changes

Fix PTL-Approved column in RelMgt dashboard

Browse Source 
The PTL-Approved label is currently set as a submit requirement, so that
it appears in the review dashboards. However, in order to not block the
submit, that requirement is always satisfied (the default of 0 is above
MIN), so that column is always shown with a green "Satisfied" checkmark.

This change makes PTL-Approved a blocking submit requirement (the
default of 0 now being the MIN) while allowing the release managers to
set +1 in extreme cases where PTL approval cannot be obtained. This
should ensure that the green checkmark in the PTL-Approved column works
correctly and lets us spot which changes can be processed quickly.

Change-Id: I9d99ba7edb996e871e8bc8d2cc1c3db0197a4b9e
This commit is contained in:
Thierry Carrez
2023-04-03 11:40:04 +02:00
parent 6e4748ca35
commit 15d80f34ae
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gerrit/acls/openstack/releases.config
View File

@@ -5,15 +5,15 @@ inheritFrom = openstack/meta-config
abandon = group releases-core abandon = group releases-core
label-Code-Review = -2..+2 group releases-core label-Code-Review = -2..+2 group releases-core
label-PTL-Approved = +0..+1 group Continuous Integration Tools label-PTL-Approved = +0..+1 group Continuous Integration Tools
label-PTL-Approved = +0..+1 group releases-core
label-Workflow = -1..+1 group releases-core label-Workflow = -1..+1 group releases-core
[label "PTL-Approved"] [label "PTL-Approved"]
copyCondition = changekind:TRIVIAL_REBASE copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0 defaultValue = 0
function = NoBlock function = NoBlock
value = -1 Block value = 0 Not approved yet
value = 0 Abstain value = +1 Approved
value = +1 Approved by PTL
[receive] [receive]
requireChangeId = true requireChangeId = true