openstack/project-config
Code Issues Proposed changes

Support running script against local changes

Browse Source 
Some projects do not strictly enforce requirements changes and
developers in those project need a way to see how far away they
are from the global requirements. So we need a way to run this
script to figure out which of those items in global requirements
they would like to update in their projects.

Adding a --local optional flag and defaulting the branch to 'master'
seems to support both existing usecases in gate and the local
use case as detailed above

Change-Id: I76fcea1e2965795ebb99f2b7d649cf9a53908f09
This commit is contained in:
Davanum Srinivas 2014-12-03 07:55:02 -05:00 committed by Davanum Srinivas (dims)
parent 443126bbfc
commit 291b578f6b
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
jenkins/scripts/project-requirements-change.py
View File

@ -15,6 +15,7 @@
# License for the specific language governing permissions and limitations
# under the License.
import argparse
import os
import pkg_resources
import shlex
@ -100,8 +101,22 @@ class RequirementsList(object):
ignore_dups=True, strict=strict)
def grab_args():
"""Grab and return arguments"""
parser = argparse.ArgumentParser(
description="Check if project requirements have changed"
)
parser.add_argument('--local', action='store_true',
help='check local changes (not yet in git)')
parser.add_argument('branch', nargs='?', default='master',
help='target branch for diffs')
return parser.parse_args()
def main():
branch = sys.argv[1]
args = grab_args()
branch = args.branch
# build a list of requirements in the proposed change,
# and check them for style violations while doing so
@ -109,15 +124,16 @@ def main():
head_reqs = RequirementsList('HEAD')
head_reqs.read_all_requirements(strict=True)
# build a list of requirements already in the target branch,
# so that we can create a diff and identify what's being changed
run_command("git remote update")
run_command("git checkout remotes/origin/%s" % branch)
branch_reqs = RequirementsList(branch)
branch_reqs.read_all_requirements()
if not args.local:
# build a list of requirements already in the target branch,
# so that we can create a diff and identify what's being changed
run_command("git remote update")
run_command("git checkout remotes/origin/%s" % branch)
branch_reqs.read_all_requirements()
# switch back to the proposed change now
run_command("git checkout %s" % head)
# switch back to the proposed change now
run_command("git checkout %s" % head)
# build a list of requirements from the global list in the
# openstack/requirements project so we can match them to the changes