Use wildcard to apply system-required template

We require all projects to have the system-required template ... unless
we aren't gating them which is the case for ansible/ansible and
kata-containers/proxy. That's a bunch of boilerplate though, and zuul
now supports wildcard project configuration.

Make a wildcard config that applies to every project starting with
openstack that contains system-required. Remove the projects that didn't
have anything but that.

Change-Id: Ic1099625ae0500657e01e7cf48bce1273f7e0e24

tools/zuul-projects-checks.py

@@ -23,33 +23,6 @@ projects_yaml = 'zuul.d/projects.yaml'
 projects = yaml.safe_load(open(projects_yaml))
 
 
-def check_system_templates():
-    """Check that each repo has a system-required template."""
-
-    errors = False
-    print("\nChecking for usage of system-required")
-    print("=====================================")
-    for entry in projects:
-        project = entry['project']
-        if not project['name'].startswith('openstack'):
-            continue
-        try:
-            correct = False
-            for template in project['templates']:
-                if template == 'system-required':
-                    correct = True
-            if not correct:
-                raise
-        except:
-            print("ERROR: Project %s has no system-required template" %
-                  project['name'])
-            errors = True
-
-    if not errors:
-        print("... all fine.")
-    return errors
-
-
 def normalize(s):
     "Normalize string for comparison."
     return s.lower().replace("_", "-")
@@ -163,8 +136,7 @@ def check_voting():
 
 def check_all():
 
-    errors = check_system_templates()
+    errors = check_projects_sorted()
-    errors = check_projects_sorted() or errors
     errors = check_release_jobs() or errors
     errors = check_voting() or errors