openstack/project-config
Code Issues Proposed changes

Adjust max Code-Review possible on governance repo

Browse Source 
On this repo, we use "RollCall Vote" and "Workflow" to
determine approvals. We still need the "Code Review"
label since it allows all registered users to express
their opinions. So adjust the max value for Code-Review
to -1..+1

Change-Id: I38d11c79372cd3f44a27f281b04c4ff9246990e9
This commit is contained in:
Goutham Pacha Ravi 2024-05-03 15:15:20 -07:00
parent f0cde8e841
commit 2ba2b7861f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit/acls/openstack/governance.config
View File

@ -6,6 +6,7 @@
abandon = group Project Bootstrappers
abandon = group tech-committee-chair
exclusiveGroupPermissions = abandon label-Workflow
label-Code-Review = -1..+1 group Registered Users
label-Rollcall-Vote = -1..+1 group tech-committee
label-Workflow = -1..+0 group Change Owner
label-Workflow = -1..+1 group Project Bootstrappers
@ -19,11 +20,9 @@
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Unused -2
value = -1 This patch needs further work before it can be merged
value = 0 No score
value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE