From 2ba2b7861f4a00ea00a8679b2635ee617039f249 Mon Sep 17 00:00:00 2001 From: Goutham Pacha Ravi Date: Fri, 3 May 2024 15:15:20 -0700 Subject: [PATCH] Adjust max Code-Review possible on governance repo On this repo, we use "RollCall Vote" and "Workflow" to determine approvals. We still need the "Code Review" label since it allows all registered users to express their opinions. So adjust the max value for Code-Review to -1..+1 Change-Id: I38d11c79372cd3f44a27f281b04c4ff9246990e9 --- gerrit/acls/openstack/governance.config | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gerrit/acls/openstack/governance.config b/gerrit/acls/openstack/governance.config index 364c020b42..1e6f6b4078 100644 --- a/gerrit/acls/openstack/governance.config +++ b/gerrit/acls/openstack/governance.config @@ -6,6 +6,7 @@ abandon = group Project Bootstrappers abandon = group tech-committee-chair exclusiveGroupPermissions = abandon label-Workflow + label-Code-Review = -1..+1 group Registered Users label-Rollcall-Vote = -1..+1 group tech-committee label-Workflow = -1..+0 group Change Owner label-Workflow = -1..+1 group Project Bootstrappers @@ -19,11 +20,9 @@ copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE defaultValue = 0 function = NoBlock - value = -2 Unused -2 value = -1 This patch needs further work before it can be merged value = 0 No score value = +1 Looks good to me - value = +2 Unused +2 [label "Rollcall-Vote"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE