From 2d7b52767f6cc0ce0befb105a4448ca59ff913e4 Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Sat, 21 Oct 2017 10:12:00 +0200 Subject: [PATCH] Remove now redundant git review setup The playbooks are setting up git review, so we can remove it from the script common.sh. Change-Id: I17c50d775b8da79ee3355c675321243b890585c5 --- jenkins/scripts/common.sh | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/jenkins/scripts/common.sh b/jenkins/scripts/common.sh index 4a52145164..2246d8adcc 100644 --- a/jenkins/scripts/common.sh +++ b/jenkins/scripts/common.sh @@ -10,17 +10,10 @@ # License for the specific language governing permissions and limitations # under the License. -# Setup git so that git review works -function configure_git_review { - git config user.name "OpenStack Proposal Bot" - git config user.email "openstack-infra@lists.openstack.org" - git config gitreview.username "proposal-bot" -} - -# Setup git so that git review works, including creating a branch in -# case the repo started with a detached head. +# Setup git so that git review works: +# * git review set up is done as part of the playbooks +# * Set up a branch in case the repo started with a detached head. function setup_git { - configure_git_review # Initial state of repository is detached, create a branch to work # from. Otherwise git review will complain.