openstack/project-config
Code Issues Proposed changes

Fix comment on requirements job

Browse Source 
Currently failures of this job leave a broken comment that doesn't
match the test-result regexes, meaning that you can't see the result
in the callout box.  See [1].

I863d88e9a7ed2fd41924b8fc4a12dbea3ee2b205 fixes the root cause, but
this message is still a bit wrong because it doesn't have the
[PASSED|FAILURE] bit.

I don't really see why we need this special result at all.  If it
fails, you have to read the log anyway to figure out what is wrong, so
move the message pointing to the docs to where the failure actually
happens in the logs.

[1] https://review.openstack.org/#/c/292193/

Change-Id: Ie5e7d2318a510a5811c9131d56594e856da9dcc5
This commit is contained in:
Ian Wienand 2016-04-21 10:37:22 +10:00
parent 4e80ebfbab
commit 4f96b2727c
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jenkins/scripts/project-requirements-change.py
View File

@ -252,6 +252,8 @@ def main():
# report the results # report the results
if failed or head_reqs.failed or branch_reqs.failed: if failed or head_reqs.failed or branch_reqs.failed:
print("*** Incompatible requirement found")
print("*** See http://docs.openstack.org/developer/requirements/")
sys.exit(1) sys.exit(1)
print("Updated requirements match openstack/requirements.") print("Updated requirements match openstack/requirements.")

1
zuul/layout.yaml
View File

@ -1798,7 +1798,6 @@ jobs:
branch: ^(?!master).*$ branch: ^(?!master).*$
- name: ^gate-.*-requirements$ - name: ^gate-.*-requirements$
failure-message: Incompatible requirement found; see http://docs.openstack.org/developer/requirements/
files: files:
- '^tools/.*-requires$' - '^tools/.*-requires$'
- '^.*requirements.txt$' - '^.*requirements.txt$'