openstack/project-config
Code Issues Proposed changes

Make install-distro-packages.sh more robust

Browse Source 
Introduce a retry loop in install-distro-packages.sh which will
attempt index updates and package installation up to 3 times if the
bindep list is unsatisfied, so as to mitigate intermittent network
failures. Add a clear error message after the last try indicating
the list of packages which were not installed.

Change-Id: I595aedbc57623ee1b30bd5880abf699f95e9eb63
This commit is contained in:
Jeremy Stanley
2015-12-22 21:01:32 +00:00
parent 62b370a2d7
commit 5283222dd5
1 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
jenkins/scripts/install-distro-packages.sh
View File

@@ -15,13 +15,29 @@ else
export PACKAGES=/usr/local/jenkins/common_data/bindep-fallback.txt export PACKAGES=/usr/local/jenkins/common_data/bindep-fallback.txt
fi fi
# install all requested packages from the appropriate bindep list # an install loop, retrying to check that all requested packages are obtained
if apt-get -v >/dev/null ; then try=0
sudo apt-get update until $BINDEP -b -f $PACKAGES ; do
sudo PATH=/usr/sbin:/sbin:$PATH DEBIAN_FRONTEND=noninteractive \ if [ $try -gt 2 ] ; then
apt-get --option "Dpkg::Options::=--force-confold" \ set +x
--assume-yes install `$BINDEP -b -f $PACKAGES || true` echo -e "\nERROR: These requested packages were not installed:\n" \
else "\n`$BINDEP -b -f $PACKAGES`\n" 1>&2
sudo PATH=/usr/sbin:/sbin:$PATH yum install -y \ set -x
`$BINDEP -b -f $PACKAGES || true` exit 1
fi fi
# don't abort inside the loop, we check for the desired outcome
set +e
if apt-get -v >/dev/null ; then
sudo apt-get update
sudo PATH=/usr/sbin:/sbin:$PATH DEBIAN_FRONTEND=noninteractive \
apt-get --option "Dpkg::Options::=--force-confold" \
--assume-yes install `$BINDEP -b -f $PACKAGES`
else
sudo PATH=/usr/sbin:/sbin:$PATH yum install -y \
`$BINDEP -b -f $PACKAGES`
fi
set -e
try=$(( $try+1 ))
done