From 6b56fd81cad681c3b7ed87bbfdfebbdf00656f55 Mon Sep 17 00:00:00 2001
From: Clark Boylan <clark.boylan@gmail.com>
Date: Wed, 12 Jun 2019 13:44:47 -0700
Subject: [PATCH] Stop building control plane images

Nodepool wants to build a new image every day then delete the N+2'th
image. This is great for dynamic test nodes which never live for longer
than a few hours. Unfortunately, with boot from volume servers you
cannot delete their base image if the server is still running. This
means as soon as we use these images for control plane servers, which do
not go away after a few hours, we'll no longer be able to delete that
image a couple days later.

This will make our current nodepool install unhappy so lets avoid doing
that for now.

We can probably make improvements to nodepool to better support this use
case. At that time we can start trying this again. We will probably also
want to use a dedicated builder for that.

Note this isn't a revert because we want to wind down nodepool in such a
way that it cleans up after itself.

Change-Id: Ic45b52f6bfc803756a8f42f21c848e1fd223175f
---
 nodepool/nodepool.yaml | 30 ++----------------------------
 1 file changed, 2 insertions(+), 28 deletions(-)

diff --git a/nodepool/nodepool.yaml b/nodepool/nodepool.yaml
index 1c27d35e6d..6616ab7f2d 100644
--- a/nodepool/nodepool.yaml
+++ b/nodepool/nodepool.yaml
@@ -118,15 +118,13 @@ providers:
     region-name: DFW
     cloud: rax-control-plane
     rate: 0.001
-    diskimages: &control_plane_diskimages
-      - name: ubuntu-bionic-minimal
-        config-drive: true
+    diskimages: []
 
   - name: vexxhost-sjc1-control-plane
     region-name: sjc1
     cloud: vexxhost-control-plane
     rate: 0.001
-    diskimages: *control_plane_diskimages
+    diskimages: []
 
 diskimages:
   - name: centos-7
@@ -420,27 +418,3 @@ diskimages:
       GIT_HTTP_LOW_SPEED_TIME: '300'
       GIT_HTTP_LOW_SPEED_LIMIT: '1000'
       DIB_SHOW_IMAGE_USAGE: '1'
-  - name: ubuntu-bionic-minimal
-    pause: false
-    elements:
-      - ubuntu-minimal
-      - vm
-      - simple-init
-      - growroot
-      - openssh-server
-      - control-plane-minimal
-    release: bionic
-    env-vars:
-      TMPDIR: /opt/dib_tmp
-      DIB_CHECKSUM: '1'
-      DIB_IMAGE_CACHE: /opt/dib_cache
-      DIB_JOURNAL_SIZE: '512'
-      DIB_APT_LOCAL_CACHE: '0'
-      DIB_DISABLE_APT_CLEANUP: '1'
-      DIB_GRUB_TIMEOUT: '0'
-      # DIB_DISTRIBUTION_MIRROR excluded on purpose
-      DIB_DEBOOTSTRAP_EXTRA_ARGS: '--no-check-gpg'
-      DIB_DEBIAN_COMPONENTS: 'main,universe'
-      GIT_HTTP_LOW_SPEED_TIME: '300'
-      GIT_HTTP_LOW_SPEED_LIMIT: '1000'
-      DIB_SHOW_IMAGE_USAGE: '1'