openstack/project-config
Code Issues Proposed changes

gerrit/acls : add NO_CODE_CHANGE

Browse Source 
The old copyAllScoresIfNoChange flag defaults to true, so any ACLs
without it explicitly set to "false" (i.e. all of ours) have had the
equivalant copy-condition flag "changekind:NO_CODE_CHANGE" added
during migration (see [1]).

Any ACL's that were not specifying changekind:NO_CODE_CHANGE are
updated so that we are in sync with what is committed in Gerrit.

We know that updates that match changekind:TRIVIAL_REBASE also match
changekind:NO_CODE_CHANGE; however the migration has still added the
latter to all rules.  Thus to avoid confusion, we also add it here.

[1] https://bugs.chromium.org/p/gerrit/issues/detail?id=16839

Change-Id: I1f11c07e3786bd1a68b43d908d939fde42ddb99c
This commit is contained in:
Ian Wienand
2023-04-12 11:11:39 +10:00
parent e1f1945675
commit 6f70d89145
18 changed files with 24 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gerrit/acls/opendev/infra-specs.config
View File

@@ -5,7 +5,7 @@ label-Rollcall-Vote = -1..+1 group infra-council
label-Workflow = -1..+1 group infra-ptl
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Unused -2
@@ -15,7 +15,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Veto

4
gerrit/acls/openinfra/transparency-policy.config
View File

@@ -12,7 +12,7 @@ label-Workflow = -1..+1 group transparency-committee-chair
createSignedTag = group transparency-committee-chair
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Unused -2
@@ -22,7 +22,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -1 No

2
gerrit/acls/openstack/glance.config
View File

@@ -25,7 +25,7 @@ label-Workflow = -1..+1 group glance-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = -1 Branch Freeze

4
gerrit/acls/openstack/governance.config
View File

@@ -16,7 +16,7 @@ label-Workflow = -1..+1 group tech-committee-chair
createSignedTag = group tech-committee-chair
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Unused -2
@@ -26,7 +26,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -1 No

4
gerrit/acls/openstack/kayobe.config
View File

@@ -12,7 +12,7 @@ label-Workflow = -1..+1 group kayobe-core
toggleWipState = group kayobe-core
[label "Backport-Candidate"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport
@@ -22,7 +22,7 @@ value = +1 Proposed Backport
value = +2 Should Backport
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = -1 Branch Freeze

4
gerrit/acls/openstack/kolla.config
View File

@@ -12,7 +12,7 @@ label-Workflow = -1..+1 group kolla-core
toggleWipState = group kolla-core
[label "Backport-Candidate"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport
@@ -22,7 +22,7 @@ value = +1 Proposed Backport
value = +2 Should Backport
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = -1 Branch Freeze

2
gerrit/acls/openstack/monasca-ui.config
View File

@@ -11,7 +11,7 @@ label-Workflow = -1..+1 group horizon-core
label-Workflow = -1..+1 group monasca-core
[label "Review-Priority"]
copyCondition = is:MAX
copyCondition = changekind:NO_CODE_CHANGE OR is:MAX
defaultValue = 0
function = NoBlock
value = -1 Branch Freeze

2
gerrit/acls/openstack/monasca.config
View File

@@ -8,7 +8,7 @@ label-Review-Priority = -1..+2 group monasca-core
label-Workflow = -1..+1 group monasca-core
[label "Review-Priority"]
copyCondition = is:MAX
copyCondition = changekind:NO_CODE_CHANGE OR is:MAX
defaultValue = 0
function = NoBlock
value = -1 Branch Freeze

2
gerrit/acls/openstack/nova-specs.config
View File

@@ -9,7 +9,7 @@ label-Review-Priority = +0..+2 group nova-specs-core
label-Workflow = -1..+1 group nova-specs-core
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = 0 Default Priority

2
gerrit/acls/openstack/nova.config
View File

@@ -28,7 +28,7 @@ label-Workflow = -1..+1 group nova-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = 0 Default Priority

1
gerrit/acls/openstack/openstacksdk.config
View File

@@ -26,6 +26,7 @@ label-Workflow = -1..+1 group openstacksdk-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Allow-Post-Review"]
copyCondition = changekind:NO_CODE_CHANGE
defaultValue = 0
function = NoBlock
value = 0 Abstain

2
gerrit/acls/openstack/os-vif.config
View File

@@ -30,7 +30,7 @@ label-Workflow = -1..+1 group os-vif-core
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = 0 Default Priority

2
gerrit/acls/openstack/placement.config
View File

@@ -28,7 +28,7 @@ label-Workflow = -1..+1 group placement-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = 0 Default Priority

2
gerrit/acls/openstack/python-novaclient.config
View File

@@ -27,7 +27,7 @@ label-Workflow = -1..+1 group nova-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyCondition = is:ANY
copyCondition = changekind:NO_CODE_CHANGE OR is:ANY
defaultValue = 0
function = NoBlock
value = 0 Default Priority

2
gerrit/acls/openstack/release-test.config
View File

@@ -8,7 +8,7 @@ label-PTL-Approved = +0..+1 group Continuous Integration Tools
label-Workflow = -1..+1 group releases-core
[label "PTL-Approved"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = 0 Abstain

2
gerrit/acls/openstack/releases.config
View File

@@ -9,7 +9,7 @@ label-PTL-Approved = +0..+1 group releases-core
label-Workflow = -1..+1 group releases-core
[label "PTL-Approved"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = 0 Not approved yet

4
gerrit/acls/starlingx/governance.config
View File

@@ -12,7 +12,7 @@ label-Workflow = -1..+1 group stx-tech-steering-committee-secretary
createSignedTag = group stx-tech-steering-committee-secretary
[label "Code-Review"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Unused -2
@@ -22,7 +22,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyCondition = changekind:TRIVIAL_REBASE
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -1 No

2
gerrit/acls/x/monasca-vagrant.config
View File

@@ -5,7 +5,7 @@ label-Review-Priority = -1..+2 group monasca-core
label-Workflow = -1..+1 group monasca-core
[label "Review-Priority"]
copyCondition = is:MAX
copyCondition = changekind:NO_CODE_CHANGE OR is:MAX
defaultValue = 0
function = NoBlock
value = -1 Branch Freeze