From 707cf6cd825b5ed31c85ef3aeb146a9ba1e6b0ef Mon Sep 17 00:00:00 2001
From: Andreas Jaeger <aj@suse.com>
Date: Tue, 5 Dec 2017 09:32:05 -0600
Subject: [PATCH] Improve zanata-cli download

Improve the code as suggested during code review.

Co-Authored-By: David Moreau Simard <dmsimard@redhat.com>
Change-Id: I51a948d0ec590f9e1db2f9f60287a360bb8ca362
---
 roles/prep-zanata/tasks/main.yaml | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/roles/prep-zanata/tasks/main.yaml b/roles/prep-zanata/tasks/main.yaml
index b7c0406c16..1cf5d54c83 100644
--- a/roles/prep-zanata/tasks/main.yaml
+++ b/roles/prep-zanata/tasks/main.yaml
@@ -30,15 +30,25 @@
   unarchive:
     src: "/opt/cache/files/zanata-cli-{{ zanata_client_version }}-dist.tar.gz"
     remote_src: yes
-    dest: "/opt/zanata"
+    dest: /opt/zanata
     creates: "/opt/zanata/zanata-cli-{{ zanata_client_version }}/bin/zanata-cli"
   when: cached_client.stat.exists
 
-- name: Download and extract zanata client tarball
+- name: Download Zanata client archive
+  get_url:
+    url: "https://search.maven.org/remotecontent?filepath=org/zanata/zanata-cli/{{ zanata_client_version }}/zanata-cli-{{ zanata_client_version }}-dist.tar.gz"
+    dest: "/tmp/zanata-cli-{{ zanata_client_version }}-dist.tar.gz"
+    checksum: "sha256:{{ zanata_client_checksum }}"
+    register: result
+    until: result | success
+    retries: 5
+    delay: 5
+  when: not cached_client.stat.exists
+
+- name: Extract Zanata client archive
   unarchive:
-    src: "https://search.maven.org/remotecontent?filepath=org/zanata/zanata-cli/{{ zanata_client_version }}/zanata-cli-{{ zanata_client_version }}-dist.tar.gz"
-    remote_src: yes
-    dest: "/opt/zanata/"
+    src: "/tmp/zanata-cli-{{ zanata_client_version }}-dist.tar.gz"
+    dest: /opt/zanata
     creates: "/opt/zanata/zanata-cli-{{ zanata_client_version }}/bin/zanata-cli"
   when: not cached_client.stat.exists