Browse Source

Update REVIEWING.rst for check-requirements job

Recent review Id8e5d55e34ec3b3d555b5482e13f99c2561e871e removed
check-requirements job without removing the project from
projects.txt in requirements repo. It caused a voting gate to
fail all the reviews submitted.

Updated REVIEWING.rst to verify this before approving
removal of check-requirements job.

Change-Id: I7b5e7665411117db1f524cd644f1a9c645e6cbcb
Swapnil Kulkarni (coolsvap) 2 years ago
parent
commit
75d3afe191
1 changed files with 11 additions and 0 deletions
  1. 11
    0
      REVIEWING.rst

+ 11
- 0
REVIEWING.rst View File

@@ -66,3 +66,14 @@ Here are some points to look at:
66 66
 
67 67
 * Proposal jobs should not run arbitrary scripts from other
68 68
   repositories or install untrusted packages.
69
+
70
+Removing check-requirements job
71
+===============================
72
+
73
+* The http://git.openstack.org/cgit/openstack/requirements repository holds
74
+  list of projects that have check-requirements job in <root>/projects.txt.
75
+
76
+* Whenever a review is submitted for removing check-requirements job,
77
+  the reviewer should verify that the project has been removed from
78
+  projects.txt already or that this project-config change depends
79
+  on the review to remove it.

Loading…
Cancel
Save