From 75d3afe191acbb6b2b5ade80a91bc09d3f4f61e4 Mon Sep 17 00:00:00 2001 From: "Swapnil Kulkarni (coolsvap)" Date: Sat, 16 Jul 2016 08:55:57 +0530 Subject: [PATCH] Update REVIEWING.rst for check-requirements job Recent review Id8e5d55e34ec3b3d555b5482e13f99c2561e871e removed check-requirements job without removing the project from projects.txt in requirements repo. It caused a voting gate to fail all the reviews submitted. Updated REVIEWING.rst to verify this before approving removal of check-requirements job. Change-Id: I7b5e7665411117db1f524cd644f1a9c645e6cbcb --- REVIEWING.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/REVIEWING.rst b/REVIEWING.rst index d7a0c797e8..b515eb2c0e 100644 --- a/REVIEWING.rst +++ b/REVIEWING.rst @@ -66,3 +66,14 @@ Here are some points to look at: * Proposal jobs should not run arbitrary scripts from other repositories or install untrusted packages. + +Removing check-requirements job +=============================== + +* The http://git.openstack.org/cgit/openstack/requirements repository holds + list of projects that have check-requirements job in /projects.txt. + +* Whenever a review is submitted for removing check-requirements job, + the reviewer should verify that the project has been removed from + projects.txt already or that this project-config change depends + on the review to remove it.