From 861d3fb4480b30fe5bd64afdb7b62477a3f9842f Mon Sep 17 00:00:00 2001 From: Ian Wienand Date: Thu, 2 Mar 2023 10:20:31 +1100 Subject: [PATCH] gerrit/acl : Convert Review-Priority to submit-requirements Similar to Ic43f561174ebf30474b1b54be2bed02695cebedc and I83160aeec0a450f8678ecb583fb7570ac0e71f4a, this converts the existing Review-Priority rules to submit-requirements following the gerrit migration rules from [1]. These are all using "AnyWithBlock" which means that only the lowest possible vote blocks submission. Thus we replace this with a submit-requirement of "-label:Review-Priority=MIN". The function is changed to NoBlock as done by the migration tool. As with the prior change; the submit-requirement with the same name as the label will avoid us having migrations run on these ACL's and keep our gerrit in-sync with project-config. Also as with the prior change, this should have no affect for users. [1] https://gerrit-review.googlesource.com/c/gerrit/+/339542 Change-Id: Id5157b9f59082485b6aff92c4f3527fb4c8084aa --- gerrit/acls/openstack/blazar.config | 6 +++++- gerrit/acls/openstack/cinder-tempest-plugin.config | 6 +++++- gerrit/acls/openstack/cinder.config | 6 +++++- gerrit/acls/openstack/cloudkitty-dashboard.config | 6 +++++- gerrit/acls/openstack/cloudkitty.config | 6 +++++- gerrit/acls/openstack/designate-dashboard.config | 6 +++++- gerrit/acls/openstack/designate-specs.config | 6 +++++- gerrit/acls/openstack/designate-tempest-plugin.config | 6 +++++- gerrit/acls/openstack/designate.config | 6 +++++- gerrit/acls/openstack/devstack.config | 6 +++++- gerrit/acls/openstack/glance-tempest-plugin.config | 6 +++++- gerrit/acls/openstack/glance.config | 6 +++++- gerrit/acls/openstack/glance_store.config | 6 +++++- gerrit/acls/openstack/grenade.config | 6 +++++- gerrit/acls/openstack/horizon.config | 6 +++++- gerrit/acls/openstack/kayobe.config | 6 +++++- gerrit/acls/openstack/kolla.config | 6 +++++- gerrit/acls/openstack/monasca-ui.config | 6 +++++- gerrit/acls/openstack/monasca.config | 6 +++++- gerrit/acls/openstack/networking-bagpipe.config | 6 +++++- gerrit/acls/openstack/networking-bgpvpn.config | 6 +++++- gerrit/acls/openstack/networking-odl.config | 6 +++++- gerrit/acls/openstack/networking-sfc.config | 6 +++++- gerrit/acls/openstack/neutron-dynamic-routing.config | 6 +++++- gerrit/acls/openstack/neutron-fwaas-dashboard.config | 6 +++++- gerrit/acls/openstack/neutron-fwaas.config | 6 +++++- gerrit/acls/openstack/neutron-lib.config | 6 +++++- gerrit/acls/openstack/neutron-specs.config | 6 +++++- gerrit/acls/openstack/neutron-vpnaas-dashboard.config | 6 +++++- gerrit/acls/openstack/neutron-vpnaas.config | 6 +++++- gerrit/acls/openstack/neutron.config | 6 +++++- gerrit/acls/openstack/ovn-octavia-provider.config | 6 +++++- gerrit/acls/openstack/patrole.config | 6 +++++- gerrit/acls/openstack/python-designateclient.config | 6 +++++- gerrit/acls/openstack/rbd-iscsi-client.config | 6 +++++- gerrit/acls/openstack/tempest.config | 6 +++++- gerrit/acls/openstack/tripleo-ci.config | 6 +++++- gerrit/acls/openstack/zaqar-ui.config | 6 +++++- gerrit/acls/openstack/zaqar.config | 6 +++++- gerrit/acls/x/monasca-vagrant.config | 6 +++++- 40 files changed, 200 insertions(+), 40 deletions(-) diff --git a/gerrit/acls/openstack/blazar.config b/gerrit/acls/openstack/blazar.config index e35b71fcd6..4ea8116309 100644 --- a/gerrit/acls/openstack/blazar.config +++ b/gerrit/acls/openstack/blazar.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group blazar-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/cinder-tempest-plugin.config b/gerrit/acls/openstack/cinder-tempest-plugin.config index 85687b4659..dd495dd541 100644 --- a/gerrit/acls/openstack/cinder-tempest-plugin.config +++ b/gerrit/acls/openstack/cinder-tempest-plugin.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group cinder-tempest-plugin-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/cinder.config b/gerrit/acls/openstack/cinder.config index f17b32149a..0b31239d7f 100644 --- a/gerrit/acls/openstack/cinder.config +++ b/gerrit/acls/openstack/cinder.config @@ -25,7 +25,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -37,3 +37,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/cloudkitty-dashboard.config b/gerrit/acls/openstack/cloudkitty-dashboard.config index f6f3b3cf64..c838352320 100644 --- a/gerrit/acls/openstack/cloudkitty-dashboard.config +++ b/gerrit/acls/openstack/cloudkitty-dashboard.config @@ -14,7 +14,7 @@ label-Workflow = -1..+1 group horizon-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -26,3 +26,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/cloudkitty.config b/gerrit/acls/openstack/cloudkitty.config index cbba4338f0..4269e67437 100644 --- a/gerrit/acls/openstack/cloudkitty.config +++ b/gerrit/acls/openstack/cloudkitty.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group cloudkitty-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/designate-dashboard.config b/gerrit/acls/openstack/designate-dashboard.config index 4c8e883c1e..e0341cc538 100644 --- a/gerrit/acls/openstack/designate-dashboard.config +++ b/gerrit/acls/openstack/designate-dashboard.config @@ -32,7 +32,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -44,3 +44,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/designate-specs.config b/gerrit/acls/openstack/designate-specs.config index 9bdafa8de5..5492c5806f 100644 --- a/gerrit/acls/openstack/designate-specs.config +++ b/gerrit/acls/openstack/designate-specs.config @@ -11,7 +11,7 @@ toggleWipState = group designate-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -23,3 +23,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/designate-tempest-plugin.config b/gerrit/acls/openstack/designate-tempest-plugin.config index 95e13c0972..18bada40bd 100644 --- a/gerrit/acls/openstack/designate-tempest-plugin.config +++ b/gerrit/acls/openstack/designate-tempest-plugin.config @@ -12,7 +12,7 @@ toggleWipState = group designate-tempest-plugin-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -24,3 +24,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/designate.config b/gerrit/acls/openstack/designate.config index a30822398d..ba21cf9dbf 100644 --- a/gerrit/acls/openstack/designate.config +++ b/gerrit/acls/openstack/designate.config @@ -27,7 +27,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -39,3 +39,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/devstack.config b/gerrit/acls/openstack/devstack.config index 52db827777..19764b2f50 100644 --- a/gerrit/acls/openstack/devstack.config +++ b/gerrit/acls/openstack/devstack.config @@ -11,7 +11,7 @@ label-Workflow = -1..+1 group devstack-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -23,3 +23,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/glance-tempest-plugin.config b/gerrit/acls/openstack/glance-tempest-plugin.config index 0d36d10624..12f70dd2f0 100644 --- a/gerrit/acls/openstack/glance-tempest-plugin.config +++ b/gerrit/acls/openstack/glance-tempest-plugin.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group glance-tempest-plugin-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/glance.config b/gerrit/acls/openstack/glance.config index 4c186c8349..72b2b6caa7 100644 --- a/gerrit/acls/openstack/glance.config +++ b/gerrit/acls/openstack/glance.config @@ -27,7 +27,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = is:ANY defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -39,3 +39,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/glance_store.config b/gerrit/acls/openstack/glance_store.config index 5f58949a19..f38553fcf3 100644 --- a/gerrit/acls/openstack/glance_store.config +++ b/gerrit/acls/openstack/glance_store.config @@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -42,3 +42,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/grenade.config b/gerrit/acls/openstack/grenade.config index 6bfe559e3c..504be76125 100644 --- a/gerrit/acls/openstack/grenade.config +++ b/gerrit/acls/openstack/grenade.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group grenade-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/horizon.config b/gerrit/acls/openstack/horizon.config index 5960679af3..0d2aa97890 100644 --- a/gerrit/acls/openstack/horizon.config +++ b/gerrit/acls/openstack/horizon.config @@ -26,7 +26,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Release Freeze value = 0 No Priority value = +1 Important Change @@ -38,3 +38,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/kayobe.config b/gerrit/acls/openstack/kayobe.config index b075c80be5..00be955de4 100644 --- a/gerrit/acls/openstack/kayobe.config +++ b/gerrit/acls/openstack/kayobe.config @@ -24,7 +24,7 @@ value = +2 Should Backport [label "Review-Priority"] copyCondition = is:ANY defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -41,3 +41,7 @@ mergeContent = true applicableIf = is:false description = Backport candidate status submittableIf = is:true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/kolla.config b/gerrit/acls/openstack/kolla.config index 6dedda861a..569ee98561 100644 --- a/gerrit/acls/openstack/kolla.config +++ b/gerrit/acls/openstack/kolla.config @@ -24,7 +24,7 @@ value = +2 Should Backport [label "Review-Priority"] copyCondition = is:ANY defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -41,3 +41,7 @@ mergeContent = true applicableIf = is:false description = Backport candidate status submittableIf = is:true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/monasca-ui.config b/gerrit/acls/openstack/monasca-ui.config index 52428157d0..110fd8df04 100644 --- a/gerrit/acls/openstack/monasca-ui.config +++ b/gerrit/acls/openstack/monasca-ui.config @@ -13,7 +13,7 @@ label-Workflow = -1..+1 group monasca-core [label "Review-Priority"] copyCondition = is:MAX defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -25,3 +25,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/monasca.config b/gerrit/acls/openstack/monasca.config index 26858603d2..af43af286e 100644 --- a/gerrit/acls/openstack/monasca.config +++ b/gerrit/acls/openstack/monasca.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group monasca-core [label "Review-Priority"] copyCondition = is:MAX defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/networking-bagpipe.config b/gerrit/acls/openstack/networking-bagpipe.config index 2fad95b24e..398ba5547b 100644 --- a/gerrit/acls/openstack/networking-bagpipe.config +++ b/gerrit/acls/openstack/networking-bagpipe.config @@ -29,7 +29,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -41,3 +41,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/networking-bgpvpn.config b/gerrit/acls/openstack/networking-bgpvpn.config index c41f73de7d..34f8f02a01 100644 --- a/gerrit/acls/openstack/networking-bgpvpn.config +++ b/gerrit/acls/openstack/networking-bgpvpn.config @@ -29,7 +29,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -41,3 +41,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/networking-odl.config b/gerrit/acls/openstack/networking-odl.config index e37b3a281c..8d4004f522 100644 --- a/gerrit/acls/openstack/networking-odl.config +++ b/gerrit/acls/openstack/networking-odl.config @@ -29,7 +29,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -41,3 +41,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/networking-sfc.config b/gerrit/acls/openstack/networking-sfc.config index 6af513aadd..b95ef94e40 100644 --- a/gerrit/acls/openstack/networking-sfc.config +++ b/gerrit/acls/openstack/networking-sfc.config @@ -29,7 +29,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -41,3 +41,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-dynamic-routing.config b/gerrit/acls/openstack/neutron-dynamic-routing.config index fa5d7e6111..2d616e68e8 100644 --- a/gerrit/acls/openstack/neutron-dynamic-routing.config +++ b/gerrit/acls/openstack/neutron-dynamic-routing.config @@ -33,7 +33,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -45,3 +45,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-fwaas-dashboard.config b/gerrit/acls/openstack/neutron-fwaas-dashboard.config index da10f1f8ee..97815d3581 100644 --- a/gerrit/acls/openstack/neutron-fwaas-dashboard.config +++ b/gerrit/acls/openstack/neutron-fwaas-dashboard.config @@ -26,7 +26,7 @@ label-Workflow = -1..+1 group neutron-stable-maint [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -38,3 +38,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-fwaas.config b/gerrit/acls/openstack/neutron-fwaas.config index 461075a444..448d073347 100644 --- a/gerrit/acls/openstack/neutron-fwaas.config +++ b/gerrit/acls/openstack/neutron-fwaas.config @@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -42,3 +42,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-lib.config b/gerrit/acls/openstack/neutron-lib.config index 23b93796ff..67edfbe1cf 100644 --- a/gerrit/acls/openstack/neutron-lib.config +++ b/gerrit/acls/openstack/neutron-lib.config @@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -42,3 +42,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-specs.config b/gerrit/acls/openstack/neutron-specs.config index 999cb68622..69d73eaab9 100644 --- a/gerrit/acls/openstack/neutron-specs.config +++ b/gerrit/acls/openstack/neutron-specs.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group neutron-drivers-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-vpnaas-dashboard.config b/gerrit/acls/openstack/neutron-vpnaas-dashboard.config index 619fda5f12..172c88fb58 100644 --- a/gerrit/acls/openstack/neutron-vpnaas-dashboard.config +++ b/gerrit/acls/openstack/neutron-vpnaas-dashboard.config @@ -26,7 +26,7 @@ label-Workflow = -1..+1 group neutron-stable-maint [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -38,3 +38,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron-vpnaas.config b/gerrit/acls/openstack/neutron-vpnaas.config index 0d94770e07..8b5d97609d 100644 --- a/gerrit/acls/openstack/neutron-vpnaas.config +++ b/gerrit/acls/openstack/neutron-vpnaas.config @@ -33,7 +33,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -45,3 +45,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/neutron.config b/gerrit/acls/openstack/neutron.config index 1ba3976124..878e37760b 100644 --- a/gerrit/acls/openstack/neutron.config +++ b/gerrit/acls/openstack/neutron.config @@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -42,3 +42,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/ovn-octavia-provider.config b/gerrit/acls/openstack/ovn-octavia-provider.config index 845bcb4049..ca9be0cfa1 100644 --- a/gerrit/acls/openstack/ovn-octavia-provider.config +++ b/gerrit/acls/openstack/ovn-octavia-provider.config @@ -27,7 +27,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -39,3 +39,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/patrole.config b/gerrit/acls/openstack/patrole.config index cdac412f92..f423099fd7 100644 --- a/gerrit/acls/openstack/patrole.config +++ b/gerrit/acls/openstack/patrole.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group patrole-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Release Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/python-designateclient.config b/gerrit/acls/openstack/python-designateclient.config index 4b5ad219aa..2131119b9f 100644 --- a/gerrit/acls/openstack/python-designateclient.config +++ b/gerrit/acls/openstack/python-designateclient.config @@ -26,7 +26,7 @@ label-Workflow = -1..+1 group stable-maint-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -38,3 +38,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/rbd-iscsi-client.config b/gerrit/acls/openstack/rbd-iscsi-client.config index d6ff546220..18bfe4cada 100644 --- a/gerrit/acls/openstack/rbd-iscsi-client.config +++ b/gerrit/acls/openstack/rbd-iscsi-client.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group rbd-iscsi-client-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/tempest.config b/gerrit/acls/openstack/tempest.config index ad57609b53..14b242d38a 100644 --- a/gerrit/acls/openstack/tempest.config +++ b/gerrit/acls/openstack/tempest.config @@ -11,7 +11,7 @@ label-Workflow = -1..+1 group tempest-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Release Freeze value = 0 No Priority value = +1 Important Change @@ -23,3 +23,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/tripleo-ci.config b/gerrit/acls/openstack/tripleo-ci.config index 175d43339e..4a9714d5b7 100644 --- a/gerrit/acls/openstack/tripleo-ci.config +++ b/gerrit/acls/openstack/tripleo-ci.config @@ -12,7 +12,7 @@ toggleWipState = group tripleo-ci-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -24,3 +24,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/zaqar-ui.config b/gerrit/acls/openstack/zaqar-ui.config index af56039897..27d25d5600 100644 --- a/gerrit/acls/openstack/zaqar-ui.config +++ b/gerrit/acls/openstack/zaqar-ui.config @@ -10,7 +10,7 @@ label-Workflow = -1..+1 group zaqar-ui-core [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -22,3 +22,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/openstack/zaqar.config b/gerrit/acls/openstack/zaqar.config index 917fdc68b0..cefe15d8a4 100644 --- a/gerrit/acls/openstack/zaqar.config +++ b/gerrit/acls/openstack/zaqar.config @@ -25,7 +25,7 @@ label-Workflow = -1..+1 group zaqar-stable-maint [label "Review-Priority"] copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -37,3 +37,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN diff --git a/gerrit/acls/x/monasca-vagrant.config b/gerrit/acls/x/monasca-vagrant.config index 5e7eb6dbe9..cf4d9a716e 100644 --- a/gerrit/acls/x/monasca-vagrant.config +++ b/gerrit/acls/x/monasca-vagrant.config @@ -7,7 +7,7 @@ label-Workflow = -1..+1 group monasca-core [label "Review-Priority"] copyCondition = is:MAX defaultValue = 0 -function = AnyWithBlock +function = NoBlock value = -1 Branch Freeze value = 0 No Priority value = +1 Important Change @@ -19,3 +19,7 @@ requireContributorAgreement = true [submit] mergeContent = true + +[submit-requirement "Review-Priority"] +description = Review priority +submittableIf = -label:Review-Priority=MIN