openstack/project-config
Code Issues Proposed changes

Don't error about default project group for SB

Browse Source 
While having a groups entry with the same name as the repository
makes no sense for Launchpad integration, it's entirely reasonable
for projects using StoryBoard to put a project in a group which has
the same name. Stop erroring about a "default groups entry" when
use-storyboard is true.

Change-Id: I95e3a9e830361563776997f2b90d0a48ea66be01
This commit is contained in:
Jeremy Stanley
2017-04-07 17:55:51 +00:00
parent 375471856a
commit 931234be2e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/check_valid_gerrit_projects.py
View File

@@ -203,10 +203,12 @@ def main():
# Check redundant groups entry: # Check redundant groups entry:
# By default the groups entry is repo_name, no need to add this. # By default the groups entry is repo_name, no need to add this.
groups = p.get('groups') groups = p.get('groups')
if groups and len(groups) == 1 and groups[0] == repo_name: storyboard = p.get('use-storyboard', False)
if (groups and len(groups) == 1 and groups[0] == repo_name
and not storyboard):
found_errors += 1 found_errors += 1
print("ERROR: Project %s has default groups entry, remove it" % print("ERROR: Non-StoryBoard project %s has default groups entry, "
name) "remove it" % name)
if found_errors: if found_errors:
print("Found %d error(s) in %s" % (found_errors, args.infile)) print("Found %d error(s) in %s" % (found_errors, args.infile))