From 945a586f65b31935a0359f286df5a2c155369412 Mon Sep 17 00:00:00 2001 From: Andreas Jaeger Date: Fri, 3 May 2019 09:22:02 +0200 Subject: [PATCH] Check groups entry in gerrit/projects Following Icbef648e9948e0fa636dd0d15039b6fc229541ca, check that groups are a list if defined. Change-Id: I3a647c6b2debc7bb0a3a06b3f3407c4ea7e3f3e5 --- tools/check_valid_gerrit_projects.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/check_valid_gerrit_projects.py b/tools/check_valid_gerrit_projects.py index e159445192..91a8127b2a 100755 --- a/tools/check_valid_gerrit_projects.py +++ b/tools/check_valid_gerrit_projects.py @@ -253,6 +253,11 @@ def main(): found_errors += 1 print("ERROR: Non-StoryBoard project %s has default groups entry, " "remove it" % name) + # Check that groups is a list + groups = p.get('groups') + if (groups and not isinstance(groups, list)): + found_errors += 1 + print("Error: groups entry for project %s is not a list." % name) if found_errors: print("Found %d error(s) in %s" % (found_errors, args.infile))