openstack/project-config
Code Issues Proposed changes

improve error handling of clone_repo

Browse Source 
Do not explicitly return 0 at the end of the function in case set -e
doesn't work inside the function the way we expect.

Use git -C instead of a subshell.

Remove an unused variable.

Change-Id: I166563cb6e84dd5af38e11b2f69189bbf6befd0e
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
This commit is contained in:
Doug Hellmann 2018-03-28 09:05:11 -04:00
parent bf4d1c1677
commit 9e269c347e
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
roles/copy-release-tools-scripts/files/release-tools/functions
View File

@ -115,7 +115,6 @@ requirements repository is branched to merge the patch."
function clone_repo {
typeset repo="$1"
typeset branch="$2"
typeset zc
set -e
@ -130,7 +129,5 @@ function clone_repo {
# We assume the job uses a git_config task to configure git
# properly.
(cd $repo && git review -s -v)
return 0
git -C $repo review -s -v
}