remove check-gerrit-buck

Rename check-gerrit-buck to gate-gerrit-buck and remove the old
gate-gerrit-buck.

check-gerrit-buck was the last job starting with "check-". We do not
need both check- and gate- jobs. The only difference between them was
that the gate job did not publish to the tarballs site.

Change-Id: Ibde25e1b53399bdda73992ca4c016d45d73812b4

jenkins/jobs/gerrit.yaml

@@ -1,5 +1,5 @@
 - job:
-    name: check-gerrit-buck
+    name: gate-gerrit-buck
     node: 'bare-precise || bare-trusty'
 
     wrappers:
@@ -30,33 +30,6 @@
           target: 'tarballs/ci/test'
       - console-log
 
-- job:
-    name: gate-gerrit-buck
-    node: 'bare-precise || bare-trusty'
-
-    wrappers:
-      - build-timeout:
-          timeout: 40
-      - timestamps
-
-    builders:
-      - revoke-sudo
-      - install-buck
-      - shell: |
-          #!/bin/bash -xe
-          export PATH=`pwd`/buck/bin:$PATH
-          mkdir -p gerrit
-          cd gerrit
-          /usr/local/jenkins/slave_scripts/gerrit-git-prep.sh https://review.openstack.org git://git.openstack.org
-          /usr/local/jenkins/slave_scripts/version-properties.sh
-          source version.properties
-          buck clean
-          buck test --all --exclude slow
-          buck build release
-          cp buck-out/gen/release.war buck-out/gen/gerrit-$PROJECT_VER.war
-
-    publishers:
-      - console-log
 
 - job:
     name: gerrit-package-buck

zuul/layout.yaml

@@ -5017,7 +5017,7 @@ projects:
     template:
       - name: merge-check
     check:
-      - check-gerrit-buck
+      - gate-gerrit-buck
     gate:
       - gate-gerrit-buck
     post: