From 7fd554a3a564e2583c3b0fe9371c74b1c30acb93 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 4 Dec 2014 10:28:12 -0800 Subject: [PATCH] Invert post build script status logic We had the logic in the post build script conditions inverted. We unfortunately need to say onsuccess: False and onfailure: False to make this run on every job regardless of its build status. This is because the plugin treats those options as IFFs with onsuccess being evaluated first. So if onsuccess is set to True then the post build script will run if and only if the build status was successful. Similar story for onfailure. If we set them both to false then neither success nor failure is checked and we should run the script on all builds. Change-Id: I70fd948e239e8a5007b0f5813c9d5757a1742abe --- jenkins/jobs/python-jobs.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/jenkins/jobs/python-jobs.yaml b/jenkins/jobs/python-jobs.yaml index 16478ef04e..5d430efd38 100644 --- a/jenkins/jobs/python-jobs.yaml +++ b/jenkins/jobs/python-jobs.yaml @@ -47,8 +47,11 @@ builders: - zuul_swift_upload_logs_with_console: upload_source: '.tox/pep8/log' - onfailure: True - onsuccess: True + # These flags really mean only if on * when + # checked. When both set to false the post script + # should run on every job regardless of status. + onfailure: False + onsuccess: False - job-template: name: 'gate-{name}-pylint'