Update post-review zuul pipeline definiton

This change does two things. First we move the post-review definition
after gate to keep things ordered on the dashboard more consistently.
All the empty space on the right doesn't look great.

Second we replace require-approval with approval in the gerrit trigger
def. This means we only trigger when approvals are explicitly given
rather than on every event after an approval is set. I think this gives
us a bit more control and we can relax things later if necessary. But to
start this makes more sense to me.

Change-Id: Id4f8002e34f4ae4c4fceafebd577e96f9625d4e0
This commit is contained in:
Clark Boylan 2022-12-12 11:54:20 -08:00
parent e2a62415ce
commit b556947c19

View File

@ -56,31 +56,6 @@
check: 'failure' check: 'failure'
comment: false comment: false
- pipeline:
name: post-review
description: |
Patches received initial review by project trusted members enter this
pipeline to execute additional jobs. This pipeline can be used to access
secrets before gating.
success-message: Build succeeded (post-review pipeline).
failure-message: |
Build failed (post-review pipeline). For information on how to proceed, see
https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing
manager: independent
post-review: True
precedence: low
require:
gerrit:
open: True
current-patchset: True
approval:
- Allow-Post-Review: [1]
trigger:
gerrit:
- event: comment-added
require-approval:
- Allow-Post-Review: [1]
- pipeline: - pipeline:
name: gate name: gate
description: | description: |
@ -125,6 +100,31 @@
window-floor: 20 window-floor: 20
window-increase-factor: 2 window-increase-factor: 2
- pipeline:
name: post-review
description: |
Patches received initial review by project trusted members enter this
pipeline to execute additional jobs. This pipeline can be used to access
secrets before gating.
success-message: Build succeeded (post-review pipeline).
failure-message: |
Build failed (post-review pipeline). For information on how to proceed, see
https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing
manager: independent
post-review: True
precedence: low
require:
gerrit:
open: True
current-patchset: True
approval:
- Allow-Post-Review: [1]
trigger:
gerrit:
- event: comment-added
approval:
- Allow-Post-Review: [1]
- pipeline: - pipeline:
name: post name: post
description: | description: |