From c2edc2a1f0e6155bc2e21f90df3f1ff67c5d8be6 Mon Sep 17 00:00:00 2001
From: Khai Do <zaro0508@gmail.com>
Date: Thu, 19 Feb 2015 15:54:06 -0800
Subject: [PATCH] Refactor Gerrit plugin build jobs

Make the Gerrit plugin job names a little more concise and make the
job a little more generic so that users can reuse it to build other
gerrit plugins.

Change-Id: Icfba74619b1dff65999882ad9f15d7c0fdb4c666
---
 jenkins/jobs/gerrit-plugin-jobs.yaml |  8 +-----
 jenkins/jobs/projects.yaml           | 37 ++++++++++++++--------------
 zuul/layout.yaml                     |  4 +--
 3 files changed, 21 insertions(+), 28 deletions(-)

diff --git a/jenkins/jobs/gerrit-plugin-jobs.yaml b/jenkins/jobs/gerrit-plugin-jobs.yaml
index d07bc9e753..b90b58cd7b 100644
--- a/jenkins/jobs/gerrit-plugin-jobs.yaml
+++ b/jenkins/jobs/gerrit-plugin-jobs.yaml
@@ -1,6 +1,5 @@
-
 - job-template:
-    name: 'periodic-gerrit-plugin-{name}-{plugin-branch}'
+    name: '{plugin-name}-gerrit-plugin-{plugin-branch}'
     node: '{node}'
 
     wrappers:
@@ -31,8 +30,3 @@
           warfile: 'gerrit/buck-out/gen/plugins/{plugin-name}/{plugin-name}-*.jar'
           target: 'tarballs/ci/gerrit/plugins/{plugin-name}'
       - console-log
-
-- job-group:
-    name: gerrit-plugin-jobs-{plugin-branch}
-    jobs:
-      - 'periodic-gerrit-plugin-{name}-{plugin-branch}'
\ No newline at end of file
diff --git a/jenkins/jobs/projects.yaml b/jenkins/jobs/projects.yaml
index 67c0a8591d..218f9b190e 100755
--- a/jenkins/jobs/projects.yaml
+++ b/jenkins/jobs/projects.yaml
@@ -1955,6 +1955,24 @@
     jobs:
       - jenkins-plugin-jobs
 
+- project:
+    name: gerrit
+    node: 'bare-precise || bare-trusty'
+    tarball-site: tarballs.openstack.org
+    gerrit-project: 'https://git.openstack.org/openstack-infra/gerrit'
+
+    jobs:
+      - '{plugin-name}-gerrit-plugin-{plugin-branch}':
+          gerrit-branch: 'openstack/2.8.4'
+          plugin-name: 'javamelody'
+          plugin-project: 'https://gerrit.googlesource.com/plugins/{plugin-name}'
+          plugin-branch: 'stable-2.8'
+      - '{plugin-name}-gerrit-plugin-{plugin-branch}':
+          gerrit-branch: 'openstack/2.9.4'
+          plugin-name: 'javamelody'
+          plugin-project: 'https://gerrit.googlesource.com/plugins/{plugin-name}'
+          plugin-branch: 'stable-2.9'
+
 - project:
     name: gerritbot
     node: 'bare-precise || bare-trusty'
@@ -2043,25 +2061,6 @@
       - gate-{name}-tox-{envlist}:
           envlist: ical
 
-- project:
-    name: javamelody-gerrit-plugin
-    node: 'bare-precise || bare-trusty'
-    tarball-site: tarballs.openstack.org
-
-    jobs:
-      - 'gerrit-plugin-jobs-{plugin-branch}':
-          gerrit-project: 'https://git.openstack.org/openstack-infra/gerrit'
-          gerrit-branch: 'openstack/2.8.4'
-          plugin-project: 'https://gerrit.googlesource.com/plugins/javamelody'
-          plugin-name: 'javamelody'
-          plugin-branch: 'stable-2.8'
-      - 'gerrit-plugin-jobs-{plugin-branch}':
-          gerrit-project: 'https://git.openstack.org/openstack-infra/gerrit'
-          gerrit-branch: 'openstack/2.9.4'
-          plugin-project: 'https://gerrit.googlesource.com/plugins/javamelody'
-          plugin-name: 'javamelody'
-          plugin-branch: 'stable-2.9'
-
 - project:
     name: jeepyb
     node: 'bare-precise || bare-trusty'
diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index 2b91036ef1..9b2e81523a 100755
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3273,8 +3273,8 @@ projects:
       - gerrit-package
       - gerrit-package-buck
     periodic:
-      - periodic-gerrit-plugin-javamelody-gerrit-plugin-stable-2.8
-      - periodic-gerrit-plugin-javamelody-gerrit-plugin-stable-2.9
+      - javamelody-gerrit-plugin-stable-2.8
+      - javamelody-gerrit-plugin-stable-2.9
 
   - name: openstack-infra/gerritbot
     template: