From d0b96ad63907e0abf3b6fe6096924534258e8152 Mon Sep 17 00:00:00 2001 From: Sean McGinnis Date: Mon, 30 Nov 2020 09:35:51 -0600 Subject: [PATCH] [check-release-approval] Handle PTL-less projects Not all teams have PTLs now. Don't assume we will get PTL information as we check for approvals on release patches. Change-Id: Id0d6eeaf66394806374781d1cf26c087a6e90f87 Signed-off-by: Sean McGinnis --- roles/check-release-approval/files/check_approval.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/roles/check-release-approval/files/check_approval.py b/roles/check-release-approval/files/check_approval.py index f38b7a07d3..fdb0ae093e 100755 --- a/roles/check-release-approval/files/check_approval.py +++ b/roles/check-release-approval/files/check_approval.py @@ -127,7 +127,8 @@ class GerritChange(object): # Fetch PTL and release liaisons liaisons = get_liaisons(self.workspace, team) - if 'email' in govteam['ptl']: + # Some teams may be PTL-less, so don't assume we have PTL info + if 'email' in govteam.get('ptl', {}): liaisons.append(govteam['ptl']['email']) LOG.debug('%s needs %s' % (deliv_file, liaisons))