gerrit/acl : submit-requirements for deprecated NoOp function
The submit functions are deprecated in Gerrit 3.7 and replaced with submit-requirements. This starts at the replacement with ACL's currently using the NoOp function. This implements the migrations steps encded with [1] upstream. The function is changed to NoBlock, and a "non-applicable" submit-requirement of "applicableIf = is:false" and "submittableIf = is:true" is added, with the same name as the label. Since we are matching the upstream rules for idempotence -- a submit-requirement with the same name as the label, we will avoid future upgrades modifying our ACL's and getting them out of sync with what we have in project-config. From a user's point-of-view, this change itself should be a no-op. [1] https://gerrit-review.googlesource.com/c/gerrit/+/339542 Change-Id: Ic43f561174ebf30474b1b54be2bed02695cebedc
This commit is contained in:
parent
f346b72eb6
commit
dda3b6098e
|
@ -7,7 +7,7 @@ label-Workflow = -1..+1 group infra-ptl
|
||||||
[label "Code-Review"]
|
[label "Code-Review"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -2 Unused -2
|
value = -2 Unused -2
|
||||||
value = -1 This patch needs further work before it can be merged
|
value = -1 This patch needs further work before it can be merged
|
||||||
value = 0 No score
|
value = 0 No score
|
||||||
|
@ -29,3 +29,8 @@ requireChangeId = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Code-Review"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Informational vote on current revision
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -14,7 +14,7 @@ createSignedTag = group transparency-committee-chair
|
||||||
[label "Code-Review"]
|
[label "Code-Review"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -2 Unused -2
|
value = -2 Unused -2
|
||||||
value = -1 This patch needs further work before it can be merged
|
value = -1 This patch needs further work before it can be merged
|
||||||
value = 0 No score
|
value = 0 No score
|
||||||
|
@ -24,7 +24,7 @@ value = +2 Unused +2
|
||||||
[label "Rollcall-Vote"]
|
[label "Rollcall-Vote"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -1 No
|
value = -1 No
|
||||||
value = 0 Abstain
|
value = 0 Abstain
|
||||||
value = +1 Yes
|
value = +1 Yes
|
||||||
|
@ -35,3 +35,13 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Code-Review"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Informational vote on current revision
|
||||||
|
submittableIf = is:true
|
||||||
|
|
||||||
|
[submit-requirement "Rollcall-Vote"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = An informational vote from team members
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -18,7 +18,7 @@ createSignedTag = group tech-committee-chair
|
||||||
[label "Code-Review"]
|
[label "Code-Review"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -2 Unused -2
|
value = -2 Unused -2
|
||||||
value = -1 This patch needs further work before it can be merged
|
value = -1 This patch needs further work before it can be merged
|
||||||
value = 0 No score
|
value = 0 No score
|
||||||
|
@ -28,7 +28,7 @@ value = +2 Unused +2
|
||||||
[label "Rollcall-Vote"]
|
[label "Rollcall-Vote"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -1 No
|
value = -1 No
|
||||||
value = 0 Abstain
|
value = 0 Abstain
|
||||||
value = +1 Yes
|
value = +1 Yes
|
||||||
|
@ -39,3 +39,13 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Code-Review"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = An informational vote on this revision
|
||||||
|
submittableIf = is:true
|
||||||
|
|
||||||
|
[submit-requirement "Rollcall-Vote"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = An informational vote from team members
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -11,7 +11,7 @@ label-Workflow = -1..+1 group nova-specs-core
|
||||||
[label "Review-Priority"]
|
[label "Review-Priority"]
|
||||||
copyCondition = is:ANY
|
copyCondition = is:ANY
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Default Priority
|
value = 0 Default Priority
|
||||||
value = +1 Contributor Review Promise
|
value = +1 Contributor Review Promise
|
||||||
value = +2 Core Review Promise
|
value = +2 Core Review Promise
|
||||||
|
@ -22,3 +22,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Review-Priority"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Review Priority
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core
|
||||||
[label "Review-Priority"]
|
[label "Review-Priority"]
|
||||||
copyCondition = is:ANY
|
copyCondition = is:ANY
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Default Priority
|
value = 0 Default Priority
|
||||||
value = +1 Contributor Review Promise
|
value = +1 Contributor Review Promise
|
||||||
value = +2 Core Review Promise
|
value = +2 Core Review Promise
|
||||||
|
@ -41,3 +41,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Review-Priority"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Review Priority
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -27,7 +27,7 @@ label-Workflow = -1..+1 group stable-maint-core
|
||||||
|
|
||||||
[label "Allow-Post-Review"]
|
[label "Allow-Post-Review"]
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Abstain
|
value = 0 Abstain
|
||||||
value = +1 Approved for Zuul Post Review Pipeline
|
value = +1 Approved for Zuul Post Review Pipeline
|
||||||
|
|
||||||
|
@ -37,3 +37,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Allow-Post-Review"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Allow Post Review
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -32,7 +32,7 @@ label-Workflow = -1..+1 group stable-maint-core
|
||||||
[label "Review-Priority"]
|
[label "Review-Priority"]
|
||||||
copyCondition = is:ANY
|
copyCondition = is:ANY
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Default Priority
|
value = 0 Default Priority
|
||||||
value = +1 Contributor Review Promise
|
value = +1 Contributor Review Promise
|
||||||
value = +2 Core Review Promise
|
value = +2 Core Review Promise
|
||||||
|
@ -43,3 +43,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Review-Priority"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Review Priority
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -30,7 +30,7 @@ label-Workflow = -1..+1 group stable-maint-core
|
||||||
[label "Review-Priority"]
|
[label "Review-Priority"]
|
||||||
copyCondition = is:ANY
|
copyCondition = is:ANY
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Default Priority
|
value = 0 Default Priority
|
||||||
value = +1 Contributor Review Promise
|
value = +1 Contributor Review Promise
|
||||||
value = +2 Core Review Promise
|
value = +2 Core Review Promise
|
||||||
|
@ -41,3 +41,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Review-Priority"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Review Priority
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -29,7 +29,7 @@ label-Workflow = -1..+1 group stable-maint-core
|
||||||
[label "Review-Priority"]
|
[label "Review-Priority"]
|
||||||
copyCondition = is:ANY
|
copyCondition = is:ANY
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Default Priority
|
value = 0 Default Priority
|
||||||
value = +1 Contributor Review Promise
|
value = +1 Contributor Review Promise
|
||||||
value = +2 Core Review Promise
|
value = +2 Core Review Promise
|
||||||
|
@ -40,3 +40,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Review-Priority"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Review Priority
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -10,7 +10,7 @@ label-Workflow = -1..+1 group releases-core
|
||||||
[label "PTL-Approved"]
|
[label "PTL-Approved"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = 0 Abstain
|
value = 0 Abstain
|
||||||
value = +1 Approved by PTL
|
value = +1 Approved by PTL
|
||||||
|
|
||||||
|
@ -20,3 +20,8 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "PTL-Approved"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Marked as approved by the PTL
|
||||||
|
submittableIf = is:true
|
||||||
|
|
|
@ -14,7 +14,7 @@ createSignedTag = group stx-tech-steering-committee-secretary
|
||||||
[label "Code-Review"]
|
[label "Code-Review"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -2 Unused -2
|
value = -2 Unused -2
|
||||||
value = -1 This patch needs further work before it can be merged
|
value = -1 This patch needs further work before it can be merged
|
||||||
value = 0 No score
|
value = 0 No score
|
||||||
|
@ -24,7 +24,7 @@ value = +2 Unused +2
|
||||||
[label "Rollcall-Vote"]
|
[label "Rollcall-Vote"]
|
||||||
copyCondition = changekind:TRIVIAL_REBASE
|
copyCondition = changekind:TRIVIAL_REBASE
|
||||||
defaultValue = 0
|
defaultValue = 0
|
||||||
function = NoOp
|
function = NoBlock
|
||||||
value = -1 No
|
value = -1 No
|
||||||
value = 0 Abstain
|
value = 0 Abstain
|
||||||
value = +1 Yes
|
value = +1 Yes
|
||||||
|
@ -35,3 +35,13 @@ requireContributorAgreement = true
|
||||||
|
|
||||||
[submit]
|
[submit]
|
||||||
mergeContent = true
|
mergeContent = true
|
||||||
|
|
||||||
|
[submit-requirement "Code-Review"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = Code Review votes are ignored
|
||||||
|
submittableIf = is:true
|
||||||
|
|
||||||
|
[submit-requirement "Rollcall-Vote"]
|
||||||
|
applicableIf = is:false
|
||||||
|
description = An informational vote from team members
|
||||||
|
submittableIf = is:true
|
||||||
|
|
Loading…
Reference in New Issue