openstack/project-config
Code Issues Proposed changes

Merge "[check-approval] Use committer instead of owner"

Browse Source
This commit is contained in:
Zuul 2020-04-12 16:59:56 +00:00 committed by Gerrit Code Review
commit e38e6cee44
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
roles/check-release-approval/files/check_approval.py
View File

@ -87,10 +87,11 @@ class GerritChange(object):
raw, raw.url, trimmed) raw, raw.url, trimmed)
raise raise
# Extract approvers from JSON data. Approvers include change owner # Extract approvers from JSON data. Approvers include last committer
# and anyone who voted Code-Review+1. NB: Gerrit does not fill # and anyone who voted Code-Review+1. NB: Gerrit does not fill
# labels.CodeReview.all unless there is a vote already # labels.CodeReview.all unless there is a vote already
self.approvers = [decoded['owner']['email']] last_revision = decoded['revisions'][decoded['current_revision']]
self.approvers = [last_revision['uploader']['email']]
if 'all' in decoded['labels']['Code-Review']: if 'all' in decoded['labels']['Code-Review']:
self.approvers.extend([ self.approvers.extend([
i['email'] i['email']