Always publish infra documents

Switch from  release-tox-docs-infra to publish-tox-docs-infra.

release-tox-docs-infra only publishes at release time while
publish-tox-docs-infra publishes after each merge.

OpenStack and Zuul publish after each merge - and most of the OpenDev
repos as well. Let's use the same pattern everywhere.

Remove also the now unused publish job.

Needed-By: https://review.opendev.org/682223
Change-Id: I04ce163629fa6171fc44e82bb2f60e55b030b645

zuul.d/jobs.yaml

@@ -496,19 +496,6 @@
     secrets:
       - site_specs
 
-- job:
-    name: publish-tox-docs-infra
-    parent: publish-openstack-tox-docs-base
-    description: |
-      Publish the results of the tox docs job to
-      /afs/.openstack.org/docs/infra/{{ zuul.project.short_name }}
-    final: true
-    post-run:
-      - playbooks/sphinx/post-infra.yaml
-    vars:
-      afs_subpath: "/infra/{{ zuul.project.short_name }}"
-      bindep_profile: compile doc
-
 - job:
     name: promote-tox-docs-infra
     parent: opendev-promote-docs-base

zuul.d/projects.yaml

@@ -95,7 +95,7 @@
       - openstack-python-jobs-no-constraints
       - openstack-python35-jobs-no-constraints
       - publish-to-pypi
-      - release-tox-docs-infra
+      - publish-tox-docs-infra
     check:
       jobs:
         - tox-cover
@@ -142,7 +142,7 @@
       - openstack-python-jobs-no-constraints
       - openstack-python35-jobs-no-constraints
       - publish-to-pypi
-      - release-tox-docs-infra
+      - publish-tox-docs-infra
 
 - project:
     name: opendev/git-review
@@ -150,7 +150,7 @@
       - openstack-python-jobs-no-constraints
       - openstack-python35-jobs-no-constraints
       - publish-to-pypi
-      - release-tox-docs-infra
+      - publish-tox-docs-infra
 
 - project:
     name: opendev/glean
@@ -1258,7 +1258,7 @@
     templates:
       - openstack-python-jobs-no-constraints
       - openstack-python35-jobs-no-constraints
-      - release-tox-docs-infra
+      - publish-tox-docs-infra
       - publish-to-pypi
     check:
       jobs: