diff --git a/jenkins/scripts/common_translation_update.sh b/jenkins/scripts/common_translation_update.sh index da5bf0cdae..3b45b600c3 100644 --- a/jenkins/scripts/common_translation_update.sh +++ b/jenkins/scripts/common_translation_update.sh @@ -157,6 +157,8 @@ EOF # See if there is an open change in the zanata/translations # topic. If so, get the change id for the existing change for use # in the commit msg. + # Function setup_commit_message will set CHANGE_ID if a change + # exists and will always set COMMIT_MSG. setup_commit_message $FULL_PROJECT proposal-bot $branch $TOPIC "$INITIAL_COMMIT_MSG" # If the open change an already approved, let's not queue a new diff --git a/jenkins/scripts/propose_app_catalog_update.sh b/jenkins/scripts/propose_app_catalog_update.sh index 7052845424..b6818093c5 100755 --- a/jenkins/scripts/propose_app_catalog_update.sh +++ b/jenkins/scripts/propose_app_catalog_update.sh @@ -23,30 +23,9 @@ SUCCESS=0 setup_git -change_id="" -# See if there is an open change in the detect-dead-links topic -# If so, get the change id for the existing change for use in the -# commit msg. -change_info=$(ssh -p 29418 $USERNAME@review.openstack.org gerrit query --current-patch-set status:open project:$PROJECT topic:$TOPIC owner:$USERNAME) -previous=$(echo "$change_info" | grep "^ number:" | awk '{print $2}') -if [ -n "$previous" ]; then - change_id=$(echo "$change_info" | grep "^change" | awk '{print $2}') - # read return a non zero value when it reaches EOF. Because we use a - # heredoc here it will always reach EOF and return a nonzero value. - # Disable -e temporarily to get around the read. - # The reason we use read is to allow for multiline variable content - # and variable interpolation. Simply double quoting a string across - # multiple lines removes the newlines. - set +e - read -d '' COMMIT_MSG <