openstack/project-config
Code Issues Proposed changes

[release-tool] check-approval use only governance data

Browse Source 
Release liaisons data is duplicated over openstack/releases and
openstack/governance repository. This patch removes the use of the
former repository and relies only on the latter repository as
single source of truth.

Depends-On: https://review.opendev.org/c/openstack/releases/+/989164
Co-Authored-by: Stephen Finucane <sfinucan@redhat.com>
Change-Id: Ic9ecf8362a7e0daff88286c37f42a5a92a1ae4e5
Signed-off-by: Elod Illes <elod.illes@est.tech>
This commit is contained in:
Elod Illes
2026-05-19 18:50:10 +02:00
co-authored by Stephen Finucane
parent 31779254eb
commit f78c6e4791
1 changed files with 7 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
roles/check-release-approval/files/check_approval.py
+7 -23
View File
@@ -43,17 +43,6 @@ def get_team(workspace, deliverablefile):
return team
def get_liaisons(workspace, team):
filename = os.path.join(workspace, 'data/release_liaisons.yaml')
with open(filename, 'r') as lfile:
liaisons = yaml.safe_load(lfile)
if team in liaisons:
return [i['email'] for i in liaisons[team]]
else:
print('WARNING: %s team does not exist in liaisons file' % team)
return []
class GerritChange(object):
def __init__(self, args):
@@ -125,21 +114,16 @@ class GerritChange(object):
approved = False
break
# Fetch release liaisons from data/release_liaisons.yaml
liaisons = get_liaisons(self.workspace, team)
# Some teams follow the "distributed project lead" governance
# model so they are PTL-less but they have release liaisons
# defined. Fetch those liaisons.
if govteam.get('leadership_type') == 'distributed':
distributed_release_liaisons = govteam['liaisons']['release']
for liaison in distributed_release_liaisons:
liaisons.append(liaison['email'])
# Fetch PTL's email address (note: some teams may be PTL-less,
# so don't assume we have PTL info)
if 'email' in govteam.get('ptl', {}):
liaisons.append(govteam['ptl']['email'])
liaisons = set()
if govteam.get('leadership_type', {}) == 'ptl':
# Fetch PTL's email address
liaisons.add(govteam['ptl']['email'])
if release_liaisons := govteam.get('liaisons', {}).get('release'):
for liaison in release_liaisons:
liaisons.add(liaison['email'])
LOG.debug('%s needs %s' % (deliv_file, liaisons))
for approver in self.approvers: