Capitalize ERROR for all project-config specific tests, so
that errors can found easily.
Add missing ERROR marks.
Change-Id: I1d7e1077de62945647e0329462016a34eaabd83e
Update our testing to only check upstream if we haven't imported the
repo into openstack. This will address test failues when users
deleted the upstream repo before removing it from
gerrit/projects.yaml.
Change-Id: I6bd9fe9841dee8be352ed17af44b4cf9cea397fd
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
When importing projects, check that they do not contain a simple
"stable" branch as that will block creation of "stable/RELEASE" branches
like "stable/mitaka".
Similar for "feature".
Change-Id: Ia190fdbddf9029149b54e686aa0e82fe040b6733
Check the following common problems with gerrit ACL lines:
* Wrong path
* Non-existence of a referenced file
* Redundant setting of acl-config with default value
Remove redundant entries that the script found.
Add acl-config for freezer-specs since no ACL existed.
Add acl-config for vinz-webclient since no ACL existed,
this was in original change I1706332f911ad9c8887d1e40613b06cbeb5e1143.
Change-Id: I6b9fc6d2ff1cd5a1f871975608947d6fe763b500
This checks out the upstream git projects (unless we use track-upstream)
and prints some information about it.
Note this checks for all upstream repositories but since those are
cleaned up regularly, this should be fine.
It fails if the there is no remote master branch.
Reindent the original code as main function.
Change-Id: Ie469905f48e4bc1a408fb9e731f95b2b735a6a02
Add a very simple check for some common typos that might appear in the
descriptions.
Correct existing typos as found by the check
Change-Id: I6edd833de8544e44750c3a3fb49a065f99a18499
Previously labels were only being checked for validity if an upstream
was given due to a premature 'continue' if no upstream is given before
checking labels.
Change-Id: I7dd564d59a30ca14bbad4044a985ba08fbe55ca5
* Fix print syntax in check_valid_gerrit_projects.py
* tox.ini: jenkins-project env works also on Python 3, no need to force
Python 2.7
Change-Id: I3c643470c6b5db666aeab208c615382719f8768d
There are a lot of missing descriptions in Gerrit's project list. Add
a bunch of them, which are hopefully correct. *-attic has been ignored
because 'meh'. Fix check_valid_gerrit_projects to also enforce
descriptions for more groups.
Drive-by some description changes.
Change-Id: Ib77dc40842b948c86a6bb0e8b52358e3c94cd0ce
Make descriptions mandatory for stackforge and
openstack-dev projects - and add
missing descriptions for all projects in these namespaces
so that the check passes.
This check can be enhanced iteratively for further namespaces.
Change-Id: I263a58484f6399c74328e870ec1a77c041afa7cb
Rename check_upstream_url_scheme.py to check_valid_gerrit_projects.py
and extend the check so that:
* It shows all errors, not only the first one
* It checks that the keywords are valid
This was triggered by seen twice in a week the keyword "description"
misspelled.
Script now outputs in error case:
Error: Upstream URLs should use a scheme in ['https://', 'http://', 'git://'],
found git@://github.com/emonty/cookiecutter-openstack.git in
openstack-dev/cookiecutter
Error: Unknown keyword 'decription' in project stackforge/ec2-driver
Found 2 error(s) in /tmp/projects.yaml
Also add the usual license header.
Change-Id: I334dcadc6fd4472fb28d379aec317c1a16dee2e2