14 Commits

Author SHA1 Message Date
Andreas Jaeger
3968468468 Consistent ERROR messages
Capitalize ERROR for all project-config specific tests, so
that errors can found easily.

Add missing ERROR marks.

Change-Id: I1d7e1077de62945647e0329462016a34eaabd83e
2016-06-30 13:16:10 +02:00
Paul Belanger
536cec4fec
Skip upstream check if we have already imported upstream
Update our testing to only check upstream if we haven't imported the
repo into openstack.  This will address test failues when users
deleted the upstream repo before removing it from
gerrit/projects.yaml.

Change-Id: I6bd9fe9841dee8be352ed17af44b4cf9cea397fd
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2016-06-08 11:26:20 -04:00
Andreas Jaeger
2a6bf90fbc Block stable/feature branch for new project imports
When importing projects, check that they do not contain a simple
"stable" branch as that will block creation of "stable/RELEASE" branches
like "stable/mitaka".
Similar for "feature".

Change-Id: Ia190fdbddf9029149b54e686aa0e82fe040b6733
2016-04-21 17:00:39 +02:00
Andreas Jaeger
6ef07db860 Add checks for gerrit ACLs
Check the following common problems with gerrit ACL lines:
* Wrong path
* Non-existence of a referenced file
* Redundant setting of acl-config with default value

Remove redundant entries that the script found.
Add acl-config for freezer-specs since no ACL existed.
Add acl-config for vinz-webclient since no ACL existed,
this was in original change I1706332f911ad9c8887d1e40613b06cbeb5e1143.

Change-Id: I6b9fc6d2ff1cd5a1f871975608947d6fe763b500
2016-04-11 16:52:26 +02:00
Andreas Jaeger
03d0680e41 Check for astra misspelling
Add common missspellings, fix also the one issue it caught.

Change-Id: Iaa6a94e3f1e3bff5f4d2986c4926078bd9090b42
2016-02-11 16:51:14 +01:00
Andreas Jaeger
2304cb56b3 Validate options in gerrit/projects
Check that only known options are used in gerrit/projects.yaml.

Change-Id: I4ba62547e71b21d8c32297ba06b4aa937f9b637e
2015-12-13 16:49:12 +01:00
Andreas Jaeger
10b18599e3 Remove global vars from check_valid_gerrit_projects.py
Replace global var with local variable usage.

Change-Id: I44640a274947f9be84232fb172f8247c15dbaee5
2015-10-22 11:00:02 +02:00
Andreas Jaeger
106f6b80e2 Check for valid upstream git projects
This checks out the upstream git projects (unless we use track-upstream)
and prints some information about it.

Note this checks for all upstream repositories but since those are
cleaned up regularly, this should be fine.

It fails if the there is no remote master branch.

Reindent the original code as main function.

Change-Id: Ie469905f48e4bc1a408fb9e731f95b2b735a6a02
2015-10-21 20:34:45 +02:00
Ian Wienand
1942b394d6 Add a simple description check for gerrit/projects.yaml
Add a very simple check for some common typos that might appear in the
descriptions.

Correct existing typos as found by the check

Change-Id: I6edd833de8544e44750c3a3fb49a065f99a18499
2015-08-27 12:38:52 +10:00
K Jonathan Harker
344bdf1faf Fix logic error in gate-project-config-projects-yaml
Previously labels were only being checked for validity if an upstream
was given due to a premature 'continue' if no upstream is given before
checking labels.

Change-Id: I7dd564d59a30ca14bbad4044a985ba08fbe55ca5
2015-06-19 13:37:03 -07:00
Victor Stinner
ceee9c0f1a Fix Python 3 issues
* Fix print syntax in check_valid_gerrit_projects.py
* tox.ini: jenkins-project env works also on Python 3, no need to force
  Python 2.7

Change-Id: I3c643470c6b5db666aeab208c615382719f8768d
2015-04-10 01:29:25 +02:00
Steve Kowalik
c1bfa625fa Add a lot of missing descriptions
There are a lot of missing descriptions in Gerrit's project list. Add
a bunch of them, which are hopefully correct. *-attic has been ignored
because 'meh'. Fix check_valid_gerrit_projects to also enforce
descriptions for more groups.

Drive-by some description changes.

Change-Id: Ib77dc40842b948c86a6bb0e8b52358e3c94cd0ce
2015-02-21 06:32:04 +11:00
Andreas Jaeger
dad4dd9a2e Check that descriptions exists in gerrit/projects.yaml
Make descriptions mandatory for stackforge and
openstack-dev projects - and add
missing descriptions for all projects in these namespaces
so that the check passes.

This check can be enhanced iteratively for further namespaces.

Change-Id: I263a58484f6399c74328e870ec1a77c041afa7cb
2014-12-03 21:37:06 +01:00
Andreas Jaeger
6ee2f2234f Check for valid entries in gerrit/projects.yaml
Rename check_upstream_url_scheme.py to check_valid_gerrit_projects.py
and extend the check so that:
* It shows all errors, not only the first one
* It checks that the keywords are valid

This was triggered by seen twice in a week the keyword "description"
misspelled.

Script now outputs in error case:
Error: Upstream URLs should use a scheme in ['https://', 'http://', 'git://'],
 found git@://github.com/emonty/cookiecutter-openstack.git in
 openstack-dev/cookiecutter
Error: Unknown keyword 'decription' in project stackforge/ec2-driver
Found 2 error(s) in /tmp/projects.yaml

Also add the usual license header.

Change-Id: I334dcadc6fd4472fb28d379aec317c1a16dee2e2
2014-12-03 15:40:40 +01:00