Define a release-approval pipeline to run the check-release-approval
job on every comment added to a release request, and set a
PTL-Approved label accordingly.
This may be considered a bit resource-intensive, however the
check-release-approval job is a fast python script that runs on
the executor, and only release requests shall go in this pipeline.
If this generates too much load, we could configure it to only run
when the comment posted contains a magic "signoff" keyword.
Another concern is that jobs other than check-release-approval would
be added to this pipeline. There does not seem to be a way in Zuul to
limit a pipeline to a specific job name or project.
Change-Id: Ieab04a4d6c02b216a59c12ec8599e7d91f4fffb1
In [0] an event type of 'comments-added' was used for the ironic
channel, but the correct event type is 'comment-added'.
[0] https://review.opendev.org/698091
Change-Id: Idd0638357aa4ed751a7e862c0e514e10b468ee9a
This removes trusty from the repo and thus from OpenDev.
Afterwards the AFS volume mirror.wheel.trustyx64 can be deleted.
Depends-On: https://review.opendev.org/702771
Depends-On: https://review.opendev.org/702818
Change-Id: I3fa4c26b0c8aeacf1af76f9046ea98edb2fcdbd0
When a gerrit comment of type Verified with value -2 is posted, send a
message to the #openstack-ironic channel.
This will raise awareness of CI job failures preventing changes from
landing, and is proposed as a trial for later refinement.
Update irc_tests.py for the dependend change to pass tests.
Change-Id: I251e9e5ea760fe5da1a8fbca7cee365dd3ae563b
Depends-On: https://review.opendev.org/#/c/698089/
This version of hacking doesn't understand f-strings as usable in
Python 3. Update to the latest and fix current issues, which are all
just formatting fixes.
Change-Id: I0a7d6f93f07477b6dd29ab143130dd9064c250be
It is possible to have two different types of dict listings for zuul
tenant project lists. The first (which we handled fine) is a dict per
project where we list which items we include from that project. The
other is a dict with global settings and a list of projects. Handle this
second case.
Change-Id: I03969da4595f4c66db36cab35ef96a33c6766002
Remove hardcoded list of namespaces with iterating over all directories
in the check of valid ACLs.
Remove parameter, we don't need to pass it in.
Be more verbose and report directories scanned and number of ACL files
read.
Change-Id: I4193ac59b431d31f3ce835c93950745e5b742418
Our linters fail due to wrong sorting, fix it.
Also, fix tools/check_valid_gerrit_config.sh, openstack-dev is dead now.
(the file needs a better fix, will do a followup)
Change-Id: Iaa330a3f9507cb065ee8b3a11d91abdadb455cf2
The Octavia team would like to enabled passive voting on patches
for backport candidates. This means that backport candidate votes
will not block a patch from merging, but will allow the team to
better track patches that should be backported.
Change-Id: Ib75714649848538e9fed171abd0b11f6fbc55503
Follow OpenDev changes:
* Use gerrit.opendev.org instead of gerrit.openstack.org
* Use opendev.org insted of git.openstack.org
* Follow move of openstack-infra/project-config to
openstack/project-config
Change-Id: Ic27ea41407abc0bdec29768e5ee5dca33f8adeda
The OpenDev rename change lost the system-required template for many
repos, add it back.
Update tools/zuul-projects-checks.py to handle this.
Change-Id: I157bdbe5cefb5cbba3fcbb18e24a8bf6e762019c
So that it's easier to use in our scripts, add some helper sugar.
First, add functions load and dump so that the library can be used
similarly to yaml without the need to construct an object first.
Then, remove the strip parameter and detect whether we're dumping
a list or not. That way people won't forget to pass or not pass
strip.
Change-Id: I204af8a89c37f36f0480de3a2e669b65354eb73c
libyaml now needs to Loader keyword to not throw a warning, use
safe_load instead everywhere.
sort_keys isn't supported for reasons surpassing understanding, so
switch to ruamel.yaml for the places where we write contents back
out.
Our ruamel.yaml wrapper strips extra leading space, which is needed
when the root object is a list. When the root object is NOT a list,
it's not needed. Add a flag to the constructor to toggle the
behavior.
For gerrit/projects.yaml this leads to a different wrapping of
description fields, which is included here.
Let ruamel.yaml handle comments
Since we've switched to ruamel.yaml, we don't need to strip
comments. Stop stripping them. Intra-list comments aren't
supported, so just remove them.
Please don't ask me why we can't have a space before openstack-merlin.
Change-Id: I72776774eabd4e397ee5e8bdd58b3632be8fd3a1
With multi-ansible support, the location of the zuul plugins/modules
has moved.
Also, handle the sort_keys argument which is new in pyyaml 5.1.
Set it to False to achieve the old behavior.
Also use python3 by default for tox tests on this repo (note,
one env still explicitly requests 2.7).
Change-Id: I8e2cf1f2276bca5a912fed52062628b3b9d0d6d9
This event is currently a noop and a new event name is in the works to
replace its intended functionality. This removes all references to the
non-functional notification. Teams can add the new replacement
notification once it's available if they want to have these.
Change-Id: Iad5fd75bc10924b483a14a449853b6b8e7c4c465
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
Check that no entries are added to zuul/projects.yaml that only contain
the project name but do not configure any jobs. These are redundant,
let's remove them.
Change-Id: I048c9011038a38fee4694defc012762079065ce5
We require all projects to have the system-required template ... unless
we aren't gating them which is the case for ansible/ansible and
kata-containers/proxy. That's a bunch of boilerplate though, and zuul
now supports wildcard project configuration.
Make a wildcard config that applies to every project starting with
openstack that contains system-required. Remove the projects that didn't
have anything but that.
Change-Id: Ic1099625ae0500657e01e7cf48bce1273f7e0e24
This is likely to not work yet, but since we aren't gating on
kata-containers/proxy we won't import job config from that repo which
would make these changes self testing. In order to get the ball moving
we need to start somewhere so start here.
This adds a vexxhost specific bionic image which we will start with
until the nodepool azure driver is tested and deployed. We should be
able to make progress on adding jobs and getting the driver going in
parallel this way.
Change-Id: Ia56c2cb3046e31e50014c8bf24342cceacb7db8a
Currently this calls out to grafyaml-validate.sh which tries to
install zuul-cloner and then pull grafyaml from that.
Since zuulv3 doesn't *have* zuul-cloner, this means the job is broken
for local testing. It works in the gate only because zuul-cloner
compatability shims are installed.
To maintain the testing-against-master behaviour, the dependent change
provides the grafyaml source in the environment; otherwise we go to
git directly.
Depends-On: https://review.openstack.org/572251
Change-Id: I3d5cd062414b77aaa70d2669730fda870ca0168e
This adds some help for building arm64 based images
Depends-On: https://review.openstack.org/539731/
Change-Id: Ife1de369264c1bcb2473894fae1e74734f0e88c3
This allows anyone in the group "designate-release-manager"
to set the priority of patches, and block non freeze patches
during RC.
This allows for more precise dashboard than relying
on stars from PTLs, and allows the team to distingush
between a procedural -2 and a release freeze -2.
Change-Id: Id7b4c6b219899fa7ed86554257264af7efe20408
The remaining bashate warnings was E042:
The return value of "local" is always 0; errors in subshells
used for declaration are thus hidden and will not trigger "set
-e".
Fix the few cases this triggered so that we don't get confused anymore
about the message.
Remove -v from bashate invocation, we don't need to print out all the
filenames anymore.
Change-Id: I47991a7040c8b9183bc72cce8e5d95b2cec7e6c5
This is not pretty, but it's the basis for what I've used to perform
the last two mass project updates.
Change-Id: Ia40f41e106066c319292c5fd229adc97f5e0014b
This adds support for the cgit-alias directive added in
https://review.openstack.org/555105. It's safe to land this change
before or after the implementation.
It also aliases the zuul project repos to git.zuul-ci.org.
Change-Id: I05a7156e092faad1457973b88537ec73012a5c96
Check that new upstream projects do not have any zuul files in there and
fail if so.
We add this check to not import a zuul config file that is broken. We
only accept zuul config files that have been gone through review.
Change-Id: Ie33d91637e812a17f3b2a2b2c75cbbadcde176ad
when running "tox -e gerrit" on a local checkout
after the tests have finshed the repo is checked out
to the HEAD commit, not the branch that was checked
out before the run.
This ensures the branch is checked out at the end
of the test.
Change-Id: I58dae937000d05c3a9b09dc4aed5362a5c56d133
