8 Commits

Author SHA1 Message Date
Andreas Jaeger
4adbecad99 Fix flake8
fix a "bug" in that the flake8 configuration in tox.ini was exclusively
selecting H231 as the only error it would report, so it was missing the
errors in the python modules (such as submit_log_processor_jobs). Due to
this being the case for a long time (since 2004) limit the more thorough
linting to the roles/ and playbooks/ directories where we'll be adding
ansible plugins/modules/etc. Also, lint in jenkins/script and nodepool.

Fix problems found.

We can lint everything with pep8 once the zuul v2 scripts are removed,
not worth patching them right now.

Change-Id: I479f010643cf3b67c183d763510f07a33400d38b
Co-Authored-By: Jesse Keating <omgjlk@us.ibm.com>
2017-10-21 18:37:10 +02:00
Andreas Jaeger
676fb1d6f3 Remove gerritbot limit test
gerritbot can now handle more than 120 channels, remove the test for it.

Change-Id: If6d1630581762aab93c979ba7852f845bc2846f5
Depends-On: Ifafeed77e640bc7b5910251c619358a8a2bd78a6
2016-12-01 19:47:50 +01:00
Frédéric Guillot
0d290bd349 Remove whitespaces and add parenthesis to print statements
Change-Id: I0cab05343b1845f92b4c606e4f2d573faf871103
2016-08-24 16:48:09 -04:00
Andreas Jaeger
3968468468 Consistent ERROR messages
Capitalize ERROR for all project-config specific tests, so
that errors can found easily.

Add missing ERROR marks.

Change-Id: I1d7e1077de62945647e0329462016a34eaabd83e
2016-06-30 13:16:10 +02:00
Andreas Jaeger
65a096a964 Check number of channels for gerritbot
We currently have a limit of 120 channels, do not allow more channels to
be set up.

Change-Id: If70f1775b2d07d9af52c83a9d234c08ac73925ce
2016-06-20 19:12:21 +02:00
Andreas Jaeger
0b4b988d9f Basic validation for gerritbot/channels.yaml
Recently a change merged that had not branches line and gerritbot
refused to start again. This could have been avoided by validation of
the file.

Test some basic validation of the yaml file to avoid breakage.

Change-Id: I2dc4a28aeac07d3fc73d3954d8fbe8f2448334e5
2015-12-23 17:53:43 +01:00
Andreas Jaeger
bb85da439d Fix return code of irc_tests.py
The scripts was always returning 0 - see
https://review.openstack.org/#/c/163876/1 which should have failed since
accessbot was not updated.

Fixed with properly wrapping main.

Change-Id: Ica8b4fa28cf9ac0009443340949ff6b32ccb9dd1
2015-03-12 16:56:11 +01:00
Andreas Jaeger
f8788e2e27 Ensure that gerritbot channels are in accessbot
Add new test that checks that channels mentioned in gerritbot are also
in accessbot.

Enhance the irc tox target so that it runs the checks, and update Zuul
so that the job is run for changes to gerritbot.

Add channels openstack-mistral and puppet-openstack to accessbot,
openstackinfra now has access to the channels. These two channels are
already in gerritbot.

Make check_irc_access.py script executable.

Change-Id: Ic68ba9a1c60854e68817fcadb1a5df2144944af7
2015-03-06 12:51:24 +01:00